Skip to content

Update save-panda to use DeviceManager - #2154

Open
noemifrisina wants to merge 8 commits into
mainfrom
save-the-panda-again
Open

Update save-panda to use DeviceManager#2154
noemifrisina wants to merge 8 commits into
mainfrom
save-the-panda-again

Conversation

@noemifrisina

Copy link
Copy Markdown
Collaborator

Fixes #2144

As all beamlines with a panda have been moved to use DeviceManager, the old way of looking for factories has been removed from this script.

Instructions to reviewer on how to test:

  1. Check tests pass
  2. Try running save-panda on a beamline network and verify it can save the configuration file correctly. Run it again on main and verify it fails there.

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.15%. Comparing base (9dad391) to head (0889ed0).

Files with missing lines Patch % Lines
src/dodal/plans/save_panda.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
- Coverage   99.16%   99.15%   -0.01%     
==========================================
  Files         353      353              
  Lines       13832    13839       +7     
==========================================
+ Hits        13716    13722       +6     
- Misses        116      117       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noemifrisina
noemifrisina marked this pull request as ready for review August 3, 2026 16:55
@noemifrisina
noemifrisina requested a review from a team as a code owner August 3, 2026 16:55
Comment thread src/dodal/plans/save_panda.py Outdated
Comment thread src/dodal/plans/save_panda.py Outdated
Comment thread src/dodal/plans/save_panda.py Outdated
@noemifrisina
noemifrisina requested a review from tpoliaw August 4, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save-panda unable to find device factory

2 participants