Update to ophyd-async 0.21.1 - #2155
Conversation
…ndLightSource/dodal into update_to_ophyd_async_0_21_1
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## update_id_logic_to_use_standard_movable #2155 +/- ##
========================================================================
Coverage 99.15% 99.15%
========================================================================
Files 356 356
Lines 13871 13871
========================================================================
Hits 13754 13754
Misses 117 117 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| get_mock_put( | ||
| mock_id_controller.apple2().gap().user_setpoint | ||
| ).assert_awaited_once_with(str(ramp_up_start)) | ||
| ).assert_awaited_once_with(ramp_up_start) |
There was a problem hiding this comment.
If it is not putting str, we have broken something.
in UndulatorGap
self.user_setpoint = epics_signal_rw(str, prefix + "BLGSET")There was a problem hiding this comment.
The issue is that we trying to rewrite Motor signals which is now causing inconsistently with the movable and fly logic changes so the signal hasn't been swapped out correctly. I think we need to apply the correct MovableLogic and use derived signals to convert between int and str.
There was a problem hiding this comment.
I am not sure if we broke anything last time we change it to movablelogic, I think we should just revert it back to its original, there isnt anything to gain by forcing a very unique single action non-stoppable device into a double action movablelogic, It introduces a lot of unnecessary boilerplate for a device that was already working perfectly.
…_ophyd_async_0_21_1
…_ophyd_async_0_21_1
…ndLightSource/dodal into update_to_ophyd_async_0_21_1
|
Blocked by #2161 |
Update to latest ophyd-async release
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}