Skip to content

Update to ophyd-async 0.21.1 - #2155

Open
oliwenmandiamond wants to merge 10 commits into
update_id_logic_to_use_standard_movablefrom
update_to_ophyd_async_0_21_1
Open

Update to ophyd-async 0.21.1#2155
oliwenmandiamond wants to merge 10 commits into
update_id_logic_to_use_standard_movablefrom
update_to_ophyd_async_0_21_1

Conversation

@oliwenmandiamond

Copy link
Copy Markdown
Contributor

Update to latest ophyd-async release

Instructions to reviewer on how to test:

  1. Check tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond
oliwenmandiamond requested a review from a team as a code owner August 4, 2026 10:09
@oliwenmandiamond
oliwenmandiamond marked this pull request as draft August 4, 2026 10:12
@oliwenmandiamond
oliwenmandiamond marked this pull request as ready for review August 4, 2026 10:20
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (145b592) to head (378e4bc).

Additional details and impacted files
@@                           Coverage Diff                            @@
##           update_id_logic_to_use_standard_movable    #2155   +/-   ##
========================================================================
  Coverage                                    99.15%   99.15%           
========================================================================
  Files                                          356      356           
  Lines                                        13871    13871           
========================================================================
  Hits                                         13754    13754           
  Misses                                         117      117           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

get_mock_put(
mock_id_controller.apple2().gap().user_setpoint
).assert_awaited_once_with(str(ramp_up_start))
).assert_awaited_once_with(ramp_up_start)

@Relm-Arrowny Relm-Arrowny Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is not putting str, we have broken something.
in UndulatorGap

        self.user_setpoint = epics_signal_rw(str, prefix + "BLGSET")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that we trying to rewrite Motor signals which is now causing inconsistently with the movable and fly logic changes so the signal hasn't been swapped out correctly. I think we need to apply the correct MovableLogic and use derived signals to convert between int and str.

@Relm-Arrowny Relm-Arrowny Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we broke anything last time we change it to movablelogic, I think we should just revert it back to its original, there isnt anything to gain by forcing a very unique single action non-stoppable device into a double action movablelogic, It introduces a lot of unnecessary boilerplate for a device that was already working perfectly.

@oliwenmandiamond
oliwenmandiamond changed the base branch from main to update_id_logic_to_use_standard_movable August 6, 2026 09:51
@oliwenmandiamond

Copy link
Copy Markdown
Contributor Author

Blocked by #2161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants