Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2157 +/- ##
==========================================
- Coverage 99.18% 97.36% -1.83%
==========================================
Files 360 368 +8
Lines 14296 14572 +276
==========================================
+ Hits 14180 14188 +8
- Misses 116 384 +268 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CoePaul
force-pushed
the
issue2132
branch
3 times, most recently
from
August 7, 2026 22:12
0412b56 to
8f4ab0d
Compare
* Internal naming conventions within the Attenuator motor positions class
had been left in prior state before recent rename
( where the rename relfected a widened scope from purely demanding motor moves
to also capture live positions of motors )
The resulting obsolescene meant names of methods and internal variables
did not reflect the wider usage scope - that is hereby fixed
* Also make internal merge of discrete indexed positions
and continuous motor axis positions into a cached property
saves the merge being recalculated - and makes its evaluation lazy
* Update tests to reflect renaming
* Improve tests with parametrized test cases
* Fix quirk in axis naming convention which used to (inadvertently)
permit leading integer in name/tag of wheel or axial motor
* Tighten test cases to capture this and other oversights in
original test suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2123
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}