Skip to content

Configure i15-1 zebra - #2159

Merged
jacob-williamson merged 2 commits into
mainfrom
xtal_bluesky_113_use_zebra_correctly
Aug 7, 2026
Merged

Configure i15-1 zebra#2159
jacob-williamson merged 2 commits into
mainfrom
xtal_bluesky_113_use_zebra_correctly

Conversation

@jacob-williamson

@jacob-williamson jacob-williamson commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #ISSUE

Required for DiamondLightSource/crystallography-bluesky#116

Instructions to reviewer on how to test:

  1. Confirm zebra is configured correctly

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob-williamson
jacob-williamson requested a review from a team as a code owner August 5, 2026 09:36
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.16%. Comparing base (879440d) to head (6414717).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2159   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         353      353           
  Lines       13873    13877    +4     
=======================================
+ Hits        13757    13761    +4     
  Misses        116      116           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@jacob-williamson
jacob-williamson merged commit 090b778 into main Aug 7, 2026
11 checks passed
@jacob-williamson
jacob-williamson deleted the xtal_bluesky_113_use_zebra_correctly branch August 7, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I15-1: Make correct use of the zebra

2 participants