Skip to content

make id gap a UndulatorGapMotor - #2167

Draft
Relm-Arrowny wants to merge 3 commits into
update_id_logic_to_use_standard_movablefrom
id_gap_motor
Draft

make id gap a UndulatorGapMotor#2167
Relm-Arrowny wants to merge 3 commits into
update_id_logic_to_use_standard_movablefrom
id_gap_motor

Conversation

@Relm-Arrowny

@Relm-Arrowny Relm-Arrowny commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Refactored UndulatorGap to inherit directly from UndulatorGapMotor, removing the nested self.motor wrapper and simplifying signal delegation.

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny changed the title make id gap a motor make id gap a UndulatorGapMotor Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.16%. Comparing base (145b592) to head (3163c4f).

Additional details and impacted files
@@                           Coverage Diff                            @@
##           update_id_logic_to_use_standard_movable    #2167   +/-   ##
========================================================================
  Coverage                                    99.15%   99.16%           
========================================================================
  Files                                          356      356           
  Lines                                        13871    13863    -8     
========================================================================
- Hits                                         13754    13747    -7     
+ Misses                                         117      116    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant