demo: convert temperature controller to getter/setter style

[coretl]

Closes #404

Retargets Tutorial 2 (getter/setter) onto the existing temperature controller demo rather than adding a second module: the existing src/fastcs/demo/controllers.py is converted to the getter/setter style in place and renamed to src/fastcs/demo/temperature_attr.py, matching how the other demo modules are named (device + style, not framework concept). One temperature backend, one temperature module.

Current-API baseline in the intended shape: TemperatureProtocol / TemperatureRampProtocol carry one method per wire command, each attribute's TemperatureIORef carries the command-building callables (read_cmd/write_cmd), and a single generic TemperatureIO just invokes them — mirroring fastcs-thorlabs-mff (MFFAttributeIO/MFFAttributeIORef/ThorlabsAPTProtocol). read_cmd/write_cmd are the getter/setter this foreshadows: #392 promotes them onto AttrRW(getter=..., setter=...) and deletes the IO/ref wrapper, while the protocol classes survive unchanged. Response parsing (attr.dtype(...)) is inline in TemperatureIO.update, not a response_handler callable.

Attributes move from the class body into __init__. That is what earns the style: each ramp bakes its index into its own protocol instance, instead of the shared IO dispatching on a name string plus a suffix. The composition and methods rungs are carried through unchanged — the ControllerVector of TemperatureRampControllers from #409, @scan and @command — so this module now covers both the getter/setter rung and the composition rung (#390), and the README ladder collapses from five modules to four accordingly.

Behaviour is preserved: same attribute names and hierarchy, same 0.2 s default poll period, same two scan groups. The launch type: in fastcs.yaml is derived from the top-level package rather than the submodule, so fastcs.TemperatureController and the checked-in schema.json survive the rename unchanged (verified by regenerating the schema).

Instructions to reviewer on how to test:

1. uv run pytest tests/demo/test_temperature_attr.py -v
2. python -m fastcs.demo run src/fastcs/demo/fastcs.yaml against the sim (tickit all src/fastcs/demo/simulation/temp_controller.yaml)

Checks for reviewer

• Would the PR title make sense to a user on a set of release notes
• Tutorial 2 now opens on the full multi-ramp controller rather than a two-attribute toy. If it should stay minimal, the fix is at docs time (DOCS: Rewrite tutorials around the examples/ controllers (one per example, single-sourced) #408): have the tutorial literalinclude only the ramp_rate/power region instead of the whole module.

Notes

• Rebased onto refactor after demo: use ControllerVector for temperature ramp sub-controllers #409/demo: cut-down Eiger REST sim + introspectable controller example #410 merged; the ControllerVector ramps and the existing tests/demo/test_controllers.py cases (test_ramps_is_controller_vector, cancel_all, update_voltages) are carried into the rewrite and the renamed test module, alongside the new wire-level protocol tests.
• Verified locally with uv run --locked tox -e pre-commit,type-checking, both green.
• Also smoke-tested end-to-end against the real tickit sim: float write+read (ramp_rate), int write+read (end), enum write (Started ramp 0 in the sim log, target → 10.0), read-only reads, update_voltages and cancel_all.
• As on demo: use ControllerVector for temperature ramp sub-controllers #409/demo: cut-down Eiger REST sim + introspectable controller example #410, this sandbox can't run the docs env (no outbound network) or PVA-touching tests (no PVA-capable socket family). Excluding those and Tango (the sandbox cannot start a Tango device server — psutil.NoSuchProcess, reproducible on refactor itself), pytest src tests --ignore=tests/benchmarking gives 282 passed. Real CI covers docs, PVA and Tango.

---

Generated by Claude Code

[coderabbitai]

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR adds the temperature-simulator example and tests, and it uses the current callback-IO baseline called for in #404.
Out of Scope Changes check	✅ Passed	The changes stay focused on the temperature demo example and its tests, with no unrelated scope evident.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding a temperature controller demo that uses getter/setter-style attribute wiring.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor-issue-404

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.25%. Comparing base (68f978a) to head (e73453b).

Additional details and impacted files

@@            Coverage Diff            @@
##           refactor     #411   +/-   ##
=========================================
  Coverage     91.25%   91.25%           
=========================================
  Files            72       72           
  Lines          2892     2892           
=========================================
  Hits           2639     2639           
  Misses          253      253           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/fastcs/demo/temperature_attr.py`:
- Around line 76-77: Update the async close method to reset the controller’s
_connected state to False after awaiting self.connection.close(), so subsequent
connection status checks correctly report the closed state.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a64717b0-dfc5-439f-a5e0-0a883dacae7c

📥 Commits

Reviewing files that changed from the base of the PR and between 3da025f and 4dbaf83.

📒 Files selected for processing (2)

• src/fastcs/demo/temperature_attr.py
• tests/demo/test_temperature_attr.py

[shihab-dls]

Just one comment regarding # type: ignore. This is idiomatic fastcs logic, with good tests, and It does show obscurity with passing setters and getters into an AttributeIORef, which I think is a good starting point. Approving.