Reduce redundant scripted vehicle and block entity work - #53
Open
frankniubi wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RenderVehicles.renderinvocation through a chainable MixinExtras@WrapOperationwithtry/finallycleanup.Motivation
Scripted vehicle callbacks can request the same full-train position data repeatedly, with the cost growing with train length. The invocation-scoped, identity-keyed single-entry cache lets adjacent callbacks for one vehicle reuse that calculation while preserving raw, unsmoothed position semantics. The remaining changes remove calculations whose results are not used.
The cache is owned by the rendering thread, bypassed by non-owner threads, strongly retained only for the wrapped invocation, and cleared on both normal and exceptional exits.
@WrapOperationdelegates through the original invocation and remains chainable with other wrappers.Verification
🤖 Generated with Claude Code