prevent social icons from overlapping in onboarding layout#4692
Open
Phoenix1808 wants to merge 3 commits into
Open
prevent social icons from overlapping in onboarding layout#4692Phoenix1808 wants to merge 3 commits into
Phoenix1808 wants to merge 3 commits into
Conversation
dosubot
Bot
added
the
size:S
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4691
The social icons (GitHub, X, Discord) were overlapping the Register button and the
"Contact us" text on the sign-up page.
The issue is in
OnboardingLayout— the icons wereabsolute bottom-4 right-4, sothey stuck to the corner of the whole page instead of staying with the form. The
register form is tall enough that it runs straight into them. Login looked fine only
because it has fewer fields.
I moved the icons out of absolute positioning and into normal flow below the form, so
they can't overlap anymore (the form just scrolls if the window is really short).
While I was there I also lined them up with the form's right edge and made all three
the same size — the Discord one was bigger than the other two.
It's a CSS-only change and applies to all the onboarding pages (register, login,
invitation, reset password).
Tested with
pnpm typecheckand biome, and checked it at a few window heights.Before / After
Before
After