Skip to content

test(spop): cover frame size handshake#32

Merged
fionera merged 2 commits into
masterfrom
agent/frame-size-tests
Jul 10, 2026
Merged

test(spop): cover frame size handshake#32
fionera merged 2 commits into
masterfrom
agent/frame-size-tests

Conversation

@fionera

@fionera fionera commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • make the fake SPOP peer complete HELLO before sending NOTIFY
  • use the mandatory HELLO fields in the fixture
  • characterize offers at 65,535, 262,140, and math.MaxUint32
  • verify AGENT-HELLO returns the accepted max-frame-size
  • join peer and protocol goroutines so handshake failures cannot leak past the test

Why

This isolates the handshake coverage before changing frame-buffer sizing. Production behavior is unchanged here. The implementation follows separately in #33.

Validation

  • go test ./...
  • go test -race ./...
  • repository custom vet analyzer
  • staticcheck ./...

@fionera
fionera marked this pull request as ready for review July 10, 2026 11:38
@fionera
fionera merged commit dce921c into master Jul 10, 2026
4 checks passed
@fionera
fionera deleted the agent/frame-size-tests branch July 10, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant