Fix transformation matrix fed to warp by using tform without inversion#89
Merged
Conversation
The tform is already inverted in a way that wrap function requires
celefthe
approved these changes
Jul 6, 2026
celefthe
left a comment
celefthe
left a comment
Member
There was a problem hiding this comment.
Great work, approved for merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code inverted tform inside the trf.warp function, which was already inverted (as is output to input transformation as per tform = trf.estimate_transform("affine", template, recording) ). Because of this, the trf.warp ended up getting the input to output transformation matrix, which is not what it requires. Fixed it in the landmarks_affine function.