vendor catch22 C sources via git submodule instead of copying - #38
Open
joshuabmoore wants to merge 9 commits into
Open
vendor catch22 C sources via git submodule instead of copying#38joshuabmoore wants to merge 9 commits into
joshuabmoore wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pycatch22currently vendors thecatch22C source files directly, which means it can drift out of sync with upstream changes. This PR replaces that approach with a git submodule sopycatch22stays synchronised withcatch22.To incorporate the C files from the
catch22submodule, the following changes were made:Changes
catch22as a submodule at v0.4.1 (.gitmodulesadded)catch22_wrap.c) out of the old src/C/ intosrc/wrapper/, keeping it underpycatch22's own controlsrc/C/, which held the old vendored C codesetup.pyto compile feature sources fromsrc/catch22/C(excluding main) plus the wrapper, with include_dirs pointing at the submodule's C directory so bare #include "..." paths resolveMANIFEST.into excludesrc/catch22/.gitso the submodule's gitlink file isn't packed into sdists (the existing graft already bundles the upstream C files, keeping sdists self-contained).github/workflows/run_unit_tests.yamlto check out submodules recursivelyREADME.mdto document local installation via git clone--recursive-submodules.github/workflows/run_unit_tests.yamlwith python 3.12 and 3.13 platforms.v0.5.0The new file structure at
pycatch22/srcis:pycatch22/src/├─
catch22 @ pinned version/# submodule → upstream catch22├─
pycatch22/# contains catch22_all├─
wrapper/# CPython wrapperNote that this is a structural change only; no changes to computation or output have been made.
catch22_allproduces identical results to before, only the C source layout and build process have changed. All existing unit tests pass under the new submodule-based structure.