Skip to content

include non-public accessors when resolving implementing properties #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koenbeuk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

include non-public accessors when resolving implementing properties #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ExpressiveSharp/Extensions/TypeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ private static MethodInfo GetImplementingMethod(this Type derivedType, MethodInf

public static PropertyInfo GetImplementingProperty(this Type derivedType, PropertyInfo propertyInfo)
{
var accessor = propertyInfo.GetAccessors()[0];
var accessor = propertyInfo.GetAccessors(true)[0];

var implementingAccessor = derivedType.GetImplementingMethod(accessor);
if (implementingAccessor == accessor)
Expand Down
22 changes: 22 additions & 0 deletions tests/ExpressiveSharp.Tests/Extensions/TypeExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,26 @@ public void GetConcreteProperty_SameDeclaringType_ReturnsOriginal()

Assert.AreEqual(animalName, result);
}

public interface IHidden
{
internal string Secret { get; }
}

public class HiddenImpl : IHidden
{
string IHidden.Secret => "s";
}

[TestMethod]
public void GetConcreteProperty_InterfacePropertyWithNonPublicAccessor_DoesNotThrow()
{
var interfaceProperty = typeof(IHidden)
.GetProperty(nameof(IHidden.Secret), BindingFlags.NonPublic | BindingFlags.Instance);
Assert.IsNotNull(interfaceProperty);

var result = typeof(HiddenImpl).GetConcreteProperty(interfaceProperty);

Assert.IsNotNull(result);
}
Comment on lines +131 to +134
}
Loading