fix(formatter-settings): disable Save when settings unchanged (closes #349) - #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds dirty tracking to
FormatterSettingsDialog. The Save button starts disabled when the local state matches the persisted settings — preventing a no-op round-trip to localStorage when the dialog is opened-and-closed without edits. A small accent-colored dot appears in the dialog title as an unsaved-changes indicator. Save re-enables after any field change.Files
src/components/editor/FormatterSettingsDialog.tsx— addsuseMemoshallowEqualdiff;disabled={!isDirty}on Save; dirty-dot in title; short-circuit inhandleSave.src/components/editor/__tests__/FormatterSettingsDialog.test.tsx— 4 new tests covering: disabled-by-default, enabled-after-change (with dirty dot), Save-click-with-no-changes-doesnt-overwrite, existing save+close flow updated to first mutate a setting.Test plan
src/components/editor/__tests__/FormatterSettingsDialog.test.tsx— 13/13 passCloses #349