Enable NYM swap provider#6023
Merged
Merged
Conversation
Contributor
Author
📸 Test evidence — real NYM swap (Sepolia ETH → NYM) executed on iOS simagent proof 1215306512581867 01 pair sepolia to nym agent proof 1215306512581867 02 nym quote powered by agent proof 1215306512581867 03 swap success agent proof 1215306512581867 04 tx details to nym Captured by the agent's in-app test run (build-and-test). |
Contributor
Author
peachbits
approved these changes
Jul 10, 2026
Register the nymswap plugin (from edge-exchange-plugins) and add its
NYM_SWAP_INIT core-plugin init ({ apiKey }, header x-api-key). The swap
plugin id is nymswap, distinct from the nym currency plugin id.
Configure the api key via env.json:
"NYM_SWAP_INIT": { "apiKey": "<key>" }
Depends on EdgeApp/edge-exchange-plugins#457.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-exchange-plugins#457
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Enable the NYM swap provider (added in edge-exchange-plugins#457).
src/util/corePlugins.ts: registernymswap: ENV.NYM_SWAP_INITinswapPlugins. The swap plugin id isnymswap, intentionally distinct from thenymcurrency plugin id (edge-core-js keys all plugins in one namespace; reusingnymsilently drops the swap plugin).src/envConfig.ts: addNYM_SWAP_INIT({ apiKey }, sent as thex-api-keyheader).Configure the key in
env.json:NYM swaps run on NYM's livenet (production) backend; the endpoints live in edge-exchange-plugins#457. GUI wiring is endpoint-agnostic, so this PR is unchanged by the testnet → livenet migration.
Verified end-to-end in the iOS simulator: ran a real mainnet swap My Ether 4 (USDT on Ethereum) → My Nym (native NYM on Nyx). The quote resolved "Powered by NYM" (6.006 USDT → 326.99 NYM) and slide-to-confirm broadcast the on-chain payin (max network fee 0.0002709 ETH), with the order entering processing ("Congratulations! Your exchange is being processed", tx category
Exchange: To NYM).Note
Low Risk
Standard swap-plugin registration and optional API key config only; no changes to auth, payments, or wallet key handling.
Overview
Enables the NYM centralized swap provider in the app by wiring the existing
nymswapexchange plugin into core plugin registration and environment config.src/util/corePlugins.tsaddsnymswap: ENV.NYM_SWAP_INITalongside other CEX swap plugins. The id isnymswap, separate from thenymwallet/currency plugin, so both can load in the shared plugin namespace.src/envConfig.tsintroducesNYM_SWAP_INITwith an optionalapiKey(for thex-api-keyheader on NYM’s API). Operators enable it viaenv.json, e.g."NYM_SWAP_INIT": { "apiKey": "<key>" }.CHANGELOG notes the new provider. Swap routing/quote UI behavior follows the same pattern as other env-gated swap plugins; the NYM backend lives in edge-exchange-plugins.
Reviewed by Cursor Bugbot for commit 9db3df5. Bugbot is set up for automated code reviews on this repo. Configure here.