Map Banxa's consolidated Google Pay and migrated ACH sell payment methods#6071
Open
j0ntz wants to merge 1 commit into
Open
Map Banxa's consolidated Google Pay and migrated ACH sell payment methods#6071j0ntz wants to merge 1 commit into
j0ntz wants to merge 1 commit into
Conversation
…hods Banxa consolidated its per-currency Google Pay PSPs into a single new PSP (PRIMERGP) and migrated ACH sell to a new code (BRDGACHSELL). Both codes were unrecognized by the strict paymentType allowlist and dropped, breaking Google Pay conversion and ACH sell. Add both codes to the allowlist and typeMap, mapping to googlepay and ach respectively.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana task
Asana: https://app.asana.com/1/9976422036640/project/1213880789473005/task/1210642564105750
Banxa consolidated its multiple per-currency Google Pay PSPs into a single new PSP and migrated its ACH sell method to a new PSP code. Edge maps Banxa
paymentTypestrings to internalFiatPaymentTypes through a strict allowlist (asBanxaPaymentType) plus atypeMap; any code not in the allowlist is dropped (viaasMaybe). The new codes were not in the map, so:PRIMERGPPSP was dropped, which is why US Google Pay conversion fell to near zero (the legacyWORLDPAYGOOGLEmethods Banxa is retiring were the only ones recognized).ZHACHSELLcode is no longer returned by Banxa (replaced byBRDGACHSELL), so ACH sell was silently broken.This adds both codes to the allowlist and
typeMap:PRIMERGP->googlepayBRDGACHSELL->achBoth Banxa integrations carry the same mapping and both are updated to stay in sync: the live ramps plugin (
src/plugins/ramps/banxa/banxaRampPlugin.ts) and the legacy provider (src/plugins/gui/providers/banxaProvider.ts).The codes were confirmed against Banxa's live production
api/payment-methodsresponse (PRIMERGPid 6142 "Google Pay",BRDGACHSELLid 6151 "ACH", both ACTIVE). The legacyWORLDPAYGOOGLEentries remain ACTIVE during Banxa's transition, so both old and new Google Pay codes are kept mapped; Banxa disables the old ones once the new code is live.Out of scope (deferred): other newly-available Banxa PSPs (PayPal, Klarna, SPEI, Khipu, VietQR, AU bank transfer) map to payment types that are not yet wired into Edge's
allowedPaymentTypes/UI and need broader work. SEPA is intentionally left disabled (deferred to Bity).Testing
Verified in-app on the iOS simulator by driving the ramps Buy and Sell flows and capturing the live
banxaRampPluginmapping against Banxa's productionapi/payment-methodsresponse:PRIMERGP#6142 (ACTIVE) ->googlepayBRDGACHSELL#6151 (ACTIVE) ->achWithout this change both would map to
undefinedand be dropped. Note: Google Pay is an Android-only payment method in Edge (buyPluginList.jsonforPlatform: android), so it does not render in the iOS payment-method list; the mapping itself was verified executing on-device against live data.tsc --noEmit, eslint, and the jest suite pass; theRecord<BanxaPaymentType, FiatPaymentType>type also enforces union/map consistency at compile time.Note
Low Risk
Small allowlist/typeMap additions in fiat ramp configuration only; no auth, payments execution, or broad UI changes.
Overview
Banxa’s API now returns new PSP codes for Google Pay (
PRIMERGP) and ACH sell (BRDGACHSELL). Edge only surfaces methods whosepaymentTypeis in a strict allowlist and mapped to an internalFiatPaymentType; anything else is dropped viaasMaybe, so these methods were invisible in buy/sell flows.This change adds both codes to
asBanxaPaymentTypeandtypeMap(PRIMERGP→googlepay,BRDGACHSELL→ach) inbanxaRampPlugin.tsand the legacybanxaProvider.ts, keeping the two integrations aligned. The CHANGELOG records the user-facing fix.Reviewed by Cursor Bugbot for commit a8b2f7b. Bugbot is set up for automated code reviews on this repo. Configure here.