feat(qol): add Movement Alert (Movement Cooldown, Time Spiral, Gatewa…#656
Open
dfrisone wants to merge 6 commits into
Open
feat(qol): add Movement Alert (Movement Cooldown, Time Spiral, Gatewa…#656dfrisone wants to merge 6 commits into
dfrisone wants to merge 6 commits into
Conversation
…y Shard) New Quality of Life page with three independently-toggleable trackers: - Movement Cooldown Alert: shows the current spec's mobility spell(s) counting down on cooldown (text/icon/bar), with per-spell overrides and a class filter grid. - Time Spiral: flashes a banner when a tracked mobility spell's cooldown is proc-reset. - Gateway Shard: Warlock-only alert when the Gateway Control Shard is usable, with a "Combat Only" mode that pauses polling out of combat. All three support Sound (via the existing LibSharedMedia-backed sound list) and Text-to-Speech alerts, and are positioned/resized through EUI's Unlock Mode rather than in-page sliders. Ported from Naowh QOL's Movement Alert feature, rewritten against this addon's own DB/widget/Unlock Mode conventions rather than copied as-is. Reviewed with a multi-pass bug hunt before commit; fixed several state-lifecycle issues (banner/frame getting stuck on screen when a tracker is disabled mid-display or reset, stale recharge timers surviving a respec, buff-active tracking not resyncing when re-enabled mid-combat, Gateway Shard fighting Unlock Mode while repositioning, a crash on custom spell text containing "%"). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfrisone
marked this pull request as ready for review
July 9, 2026 19:51
Required by the locale-keys CI check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Required by the locale-keys CI check.
# Conflicts: # Locales/_keys.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new Quality of Life feature, Movement Alert, with three independently-toggleable on-screen trackers: a Movement Cooldown Alert for the player's class mobility spell(s), a Time Spiral banner for cooldown-reset procs, and a Warlock-only Gateway Shard usability alert — each with Sound and Text-to-Speech support and full Unlock Mode positioning.
Changes
Movement Alert — Runtime
EllesmereUIQoL_MovementAlert.luaimplementing all three trackers:SPELL_ACTIVATION_OVERLAY_GLOWand flashes a countdown banner.FireTrackerAlertdispatcher: Text-to-Speech (viaC_VoiceChat.SpeakText) takes priority over a configured Sound when both are set.EllesmereUI._groupDeathSoundPaths(LibSharedMedia-backed, shared with the rest of the addon) rather than querying LibSharedMedia directly, with type-safe routing betweenPlaySound(SoundKitID) andPlaySoundFile(file path).Movement Alert — Options UI
EUI_QoL_MovementAlert_Options.luabuilding the "Movement" page: master toggle + settings cog per tracker, a 13-class filter grid, a Tracked Spells list with per-spell enable/custom-text/remove and an "Add Spell" popup, and Sound/TTS controls (including a live voice-preview dropdown) on all three trackers.Unlock Mode
EUI_MovementAlert,EUI_TimeSpiralAlert,EUI_GatewayShardAlert) under the Quality of Life group.Module Registration
Movementpage, tab, and search terms (mobility, blink, disengage, time spiral, gateway shard, etc.) to theEllesmereUIQoLmodule inEUI_QoL_Options.lua.EllesmereUI._ResetMovementAlertinto the module's existing Reset-to-defaults handler.Bug Fixes
(found in review, fixed before commit)
%or%t.Defaults
profile.movementAlert) that doesn't touch any existing profile data.