feat(damagemeters): fade-out time for icon history#667
Open
ExoJdi wants to merge 1 commit into
Open
Conversation
Adds a Fade-Out Time slider for the spell icon history (0 = keep forever). Each icon expires individually once its cast is older than the configured time, then fades its alpha to zero over 1.5s instead of vanishing abruptly. Expiry only counts down out of combat so the history stays readable through a fight. Options-page preview placeholders no longer appear in slots vacated by faded icons. Includes locale entries.
Owner
|
Thank you this is a great idea! I'm down to merge this, but it has a performance issue that needs to be addressed first. I'd want that ticker replaced with event based player_regen_enabled instead. fast tick should only happen when an icon is actually fading, otherwise just use a c_timer.after set to the next expiring icon. As a general rule for PRing in the future for EUI, any new feature needs to be event driven unless absolutely necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Fade-Out Time slider for the spell icon history (0 = keep forever). Each icon expires individually once its cast is older than the configured time, then fades its alpha to zero over 1.5s instead of vanishing abruptly. Expiry only counts down out of combat so the history stays readable through a fight. Options-page preview placeholders no longer appear in slots vacated by faded icons. Includes locale entries.