Skip to content

Character sheet: fix issues with scroll and section visibility#784

Open
Snsei987 wants to merge 4 commits into
EllesmereGaming:mainfrom
Snsei987:fix/character-sheet-issues
Open

Character sheet: fix issues with scroll and section visibility#784
Snsei987 wants to merge 4 commits into
EllesmereGaming:mainfrom
Snsei987:fix/character-sheet-issues

Conversation

@Snsei987

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes 3 bugs, maybe more:

  • When scrolling all the way down, then collapsing sections, depending on how many sections were collapsed scroll would be impossible (intended behavior with scroll frame height).
  • After a /reload, opening the character sheet and clicking up/down section button or clicking on a section title (to collapse/show it) would make the hidden sections reappears.

How was it tested?

12.0.7 only. After a /reload and in M+.

Screenshots

First issue with scroll:

Before:
image

After:
image

Second and third issues:

My config:
image

Before:
image

After:
image

Checklist

  • N/A New settings default OFF (no behavior change without opt-in)
  • N/A Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • N/A No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game, works on live retail; no load errors on the 12.1 PTR client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant