Finalize and validate NeqSim FEM notebooks after #112 - #113
Merged
Conversation
EvenSol
marked this pull request as ready for review
August 7, 2026 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #112, which was merged before the full FEniCSx/Gmsh execution workflow completed.
This PR keeps the notebooks on source-built NeqSim master and completes the runtime validation. The temporary validator patches the runtime JAR discovery, isolates the deep FEniCSx solve from headless VTK rendering, executes both notebooks in
dolfinx/lab:stable, records retained outputs and maintenance evidence, runs the repository integrity checks, and removes itself before the branch is ready to merge.Do not merge until the execution workflow has completed successfully and this PR is marked ready.