[Campaign #2899] Refresh DEXPI acceptance notebook baseline - #115
Draft
EvenSol wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
READY TO MERGE Validated head
NeqSim-Colab has no This is a readiness notification for review, not authorization to merge. Campaign issue equinor/neqsim#2899 remains unchanged until merged evidence exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of equinor/neqsim#2899. This is the smallest dependency-ready Phase 0 increment: refresh the current-master DEXPI/P&ID baseline and correct stale acceptance-notebook evidence.
Roadmap item
Phase 0 — current-master baseline/gap matrix and stale notebook correction.
The notebook previously used the deprecated
DexpiXmlWriter.writeDexpi20header-override path and asserted that the HIPPS/SIS mapping tracked in equinor/neqsim#2653 was still missing. That mapping was merged in equinor/neqsim#2654 and is present in public NeqSim 3.17.0.Changes
DexpiXmlWriter.write;Dexpi20XmlWriter.writeAndAssess;GenericAttributevalue/unit checks;Generated P&IDs, HAZOP nodes, C&E rows, SIL-related attributes, and values remain software-generated proposals/calculated evidence. This PR makes no DEXPI e.V. certification, commercial CAE interoperability, approved-for-construction, or accountable engineering-approval claim.
Validation
Fresh public-PyPI snapshot:
Resolved NeqSim 3.17.0, Python 3.12.13, OpenJDK 17.0.19, and 65 verified wheels from snapshot
20260809T090842Z-0f40dc962ea8.Passed:
Results:
CONFORMANT, zero errors;c6237492bf32778c63f6dc83b16039aadb624a140291b4b7334767a76ab733c9;3870f349952d4920f6e6fdb8840cfc6e9a6e2a3bbc85888bc4486c985b587338;scripts/check_notebook.py: 0 errors, 0 warnings;Pre-commit note: NeqSim-Colab currently has no
.pre-commit-config.yaml, and the connector-backed publication workspace is not a local Git worktree. The exact requested pre-commit and pre-push invocations therefore report the missing Git/config context rather than running hooks. The repository-defined notebook integrity gates above are the applicable configured gates and pass locally; full repository integrity remains for CI.Documentation impact
Updated the acceptance notebook and maintenance evidence. The catalog link remains unchanged and unique. No JavaDoc, public API, migration, or release-note change is required because this increment changes no NeqSim Java or Python API.
Review focus
PlantInformation.DateandPlantInformation.Timethe correct engineering-semantic determinism boundary?