Skip to content

[Campaign #2899] Refresh DEXPI acceptance notebook baseline - #115

Draft
EvenSol wants to merge 1 commit into
masterfrom
agent/dexpi-phase0-profile-audit
Draft

[Campaign #2899] Refresh DEXPI acceptance notebook baseline#115
EvenSol wants to merge 1 commit into
masterfrom
agent/dexpi-phase0-profile-audit

Conversation

@EvenSol

@EvenSol EvenSol commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Part of equinor/neqsim#2899. This is the smallest dependency-ready Phase 0 increment: refresh the current-master DEXPI/P&ID baseline and correct stale acceptance-notebook evidence.

Roadmap item

Phase 0 — current-master baseline/gap matrix and stale notebook correction.

The notebook previously used the deprecated DexpiXmlWriter.writeDexpi20 header-override path and asserted that the HIPPS/SIS mapping tracked in equinor/neqsim#2653 was still missing. That mapping was merged in equinor/neqsim#2654 and is present in public NeqSim 3.17.0.

Changes

  • generate a Proteus P&ID exchange with DexpiXmlWriter.write;
  • separately generate and assess a native DEXPI 2.0 Plant/P&ID exchange with Dexpi20XmlWriter.writeAndAssess;
  • add a current capability/evidence-boundary matrix for Proteus, native Plant/P&ID, native Process/PFD/BFD, and governed engineering packages;
  • replace substring checks with exact typed GenericAttribute value/unit checks;
  • verify GateValve, SIL 3, 2oo3, proof-test interval, closure time, safe state, and SIS mapping;
  • retain the 82 bara trip setpoint as an explicit governed-register/profile boundary;
  • verify Proteus engineering-semantic determinism after excluding only volatile export Date/Time and native DEXPI byte determinism;
  • distinguish conformance, graphical quality, named CAE round trips, and engineering approval;
  • correct semantic-graph connector layout and add descriptive figure alternative text;
  • move this notebook's maintenance evidence to a dedicated, conflict-resistant ledger shard.

Generated P&IDs, HAZOP nodes, C&E rows, SIL-related attributes, and values remain software-generated proposals/calculated evidence. This PR makes no DEXPI e.V. certification, commercial CAE interoperability, approved-for-construction, or accountable engineering-approval claim.

Validation

Fresh public-PyPI snapshot:

python scripts/bootstrap_neqsim_validation_env.py --venv /tmp/neqsim-validation-dexpi-2899-exec --neqsim-version latest --refresh --extra-package nbclient --extra-package nbconvert --extra-package ipykernel

Resolved NeqSim 3.17.0, Python 3.12.13, OpenJDK 17.0.19, and 65 verified wheels from snapshot 20260809T090842Z-0f40dc962ea8.

Passed:

MPLCONFIGDIR=/tmp/dexpi-matplotlib IPYTHONDIR=/tmp/dexpi-ipython python scripts/execute_notebook_inprocess.py notebooks/process/dexpi_safety_study_workflow.ipynb
python scripts/check_notebook.py notebooks/process/dexpi_safety_study_workflow.ipynb --ledger notebooks/maintenance_ledger/dexpi_safety_study_workflow.json --catalog <single-target validation catalog> --baseline scripts/notebook_integrity_baseline.json
python -m unittest discover -s scripts -p 'test_check_notebook.py'
jupyter nbconvert --to html --template classic notebooks/process/dexpi_safety_study_workflow.ipynb

Results:

  • 14/14 code cells executed sequentially; zero stored exceptions or stderr;
  • 14/14 focused physical, semantic, profile, loss-boundary, and determinism checks passed;
  • native DEXPI 2.0 status: CONFORMANT, zero errors;
  • Proteus semantic SHA-256 stable across repeat exports: c6237492bf32778c63f6dc83b16039aadb624a140291b4b7334767a76ab733c9;
  • native DEXPI 2.0 SHA-256 byte-stable across repeat exports: 3870f349952d4920f6e6fdb8840cfc6e9a6e2a3bbc85888bc4486c985b587338;
  • scripts/check_notebook.py: 0 errors, 0 warnings;
  • checker unit tests: 6 passed;
  • classic Jupyter/Colab-compatible HTML rendered; MathJax SVG equation and all three stored figures visually inspected at original resolution.

Pre-commit note: NeqSim-Colab currently has no .pre-commit-config.yaml, and the connector-backed publication workspace is not a local Git worktree. The exact requested pre-commit and pre-push invocations therefore report the missing Git/config context rather than running hooks. The repository-defined notebook integrity gates above are the applicable configured gates and pass locally; full repository integrity remains for CI.

Documentation impact

Updated the acceptance notebook and maintenance evidence. The catalog link remains unchanged and unique. No JavaDoc, public API, migration, or release-note change is required because this increment changes no NeqSim Java or Python API.

Review focus

  1. Is the Proteus-versus-native DEXPI capability boundary stated accurately?
  2. Is excluding only PlantInformation.Date and PlantInformation.Time the correct engineering-semantic determinism boundary?
  3. Is the trip-setpoint externalization clear enough for professional study use?

EvenSol commented Aug 9, 2026

Copy link
Copy Markdown
Owner Author

READY TO MERGE

Validated head 77057c2a422f67e0a5485f72a98c1a52225a7800:

  • GitHub Actions Notebook integrity run 31306594738: success;
  • unit-test and repository notebook-integrity CI steps: success;
  • 14/14 clean notebook cells and 14/14 focused engineering/semantic/determinism checks: passed;
  • native DEXPI 2.0 conformance: CONFORMANT, zero errors;
  • Jupyter/Colab-compatible HTML, MathJax equation, all tables, and all three figures: rendered and visually inspected;
  • documentation and focused maintenance-ledger evidence: complete;
  • PR mergeability: conflict-free;
  • review submissions, inline threads, Copilot suggestions, and conversation comments: none outstanding.

NeqSim-Colab has no .pre-commit-config.yaml; the exact hook commands are therefore not an applicable configured repository gate in this connector-backed workspace. The repository-defined unit and notebook-integrity gates pass locally and in CI.

This is a readiness notification for review, not authorization to merge. Campaign issue equinor/neqsim#2899 remains unchanged until merged evidence exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant