Skip to content

fix(build): stop emitting stray .d.ts trees from single-file bundle configs #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Exoridus wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −4
Open

fix(build): stop emitting stray .d.ts trees from single-file bundle configs #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions rollup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,14 @@ function basePlugins(options: {
];
}

// The root tsconfig inherits `declaration: true` (library profile). Only the
// `modules` build is meant to emit declarations (into dist/esm); every other
// config must switch them off, or @rollup/plugin-typescript emits the whole
// .d.ts tree as bundle assets — polluting dist/ with a duplicate declaration
// tree and inflating the Codecov bundle-analysis numbers (incompressible
// assets are counted at raw size in the gzip column).
const noDeclarations = { declaration: false, declarationMap: false } as const;

const bundled: RollupOptions = {
input: 'src/index.ts',
output: {
Expand All @@ -132,7 +140,7 @@ const bundled: RollupOptions = {
...basePlugins({
exportConditions: sourceConditions,
transform: typescript({
compilerOptions: { incremental: false },
compilerOptions: { incremental: false, ...noDeclarations },
outputToFilesystem: false,
}),
minify: 'production',
Expand All @@ -153,7 +161,7 @@ const iife: RollupOptions = {
plugins: basePlugins({
exportConditions: sourceConditions,
transform: typescript({
compilerOptions: { incremental: false },
compilerOptions: { incremental: false, ...noDeclarations },
outputToFilesystem: false,
}),
}),
Expand All @@ -172,7 +180,7 @@ const iifeMin: RollupOptions = {
...basePlugins({
exportConditions: sourceConditions,
transform: typescript({
compilerOptions: { incremental: false },
compilerOptions: { incremental: false, ...noDeclarations },
outputToFilesystem: false,
}),
minify: 'always',
Expand All @@ -197,7 +205,7 @@ const debugBundled: RollupOptions = {
plugins: basePlugins({
exportConditions: sourceConditions,
transform: typescript({
compilerOptions: { incremental: false },
compilerOptions: { incremental: false, ...noDeclarations },
outputToFilesystem: false,
}),
minify: 'production',
Expand Down
Loading