Skip to content

solucionado bug balance de situacion - #91

Open
Pabloferrandezroca wants to merge 2 commits into
FacturaScripts:mainfrom
Pabloferrandezroca:tarea4806
Open

solucionado bug balance de situacion#91
Pabloferrandezroca wants to merge 2 commits into
FacturaScripts:mainfrom
Pabloferrandezroca:tarea4806

Conversation

@Pabloferrandezroca

Copy link
Copy Markdown

solucionado el bug que al realizar un balance de situación con cuantas de doble saldo se descuadra

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22b94b059c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<null>NO</null>
</column>
<column>
<name>restriccion</name>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Populate restrictions for existing balance accounts

When this column is added on upgrade, existing balance_accounts rows keep restriccion as NULL, and BalanceAccount::matchesRestriction() treats that as unrestricted, so already-installed companies still count the pymes double-balance accounts (551/5525/5523/5524) on both sides. The only populated values are in the seed CSV, while Init::update()/copyBalancePymes() do not backfill the new field, so the fix only works for fresh seed imports; add a migration/backfill for the affected existing rows.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pabloferrandezroca faltaría añadir una migración haciendo lo que dice el comentario de Codex, para que aquellas instalaciones con el plugin ya activo se rellene esa nueva columna "restriccion" donde debe hacerlo, así el usuario no tiene que rellenarla manualmente.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants