Thoth's Gambit changes - #1106
Merged
Merged
Conversation
IridescentVoid
commented
Jun 7, 2026
s5bug
approved these changes
Jun 8, 2026
|
|
||
| "for_each.1": "Remove a list of patterns and a list from the stack, then cast the given pattern over each element of the second list.", | ||
| "for_each.2": "More specifically, for each element in the second list, it will:$(li)Create a new stack, with everything on the current stack plus that element$(li)Draw all the patterns in the first list$(li)Save all the iotas remaining on the stack to a list$(br)Then, after all is said and done, pushes the list of saved iotas onto the main stack.$(br2)No wonder all the practitioners of this art go mad.", | ||
| "for_each.1": "Remove a list of values and pattern/list of patterns from the stack, then cast the pattern(s) over each element of the first list.", |
Contributor
There was a problem hiding this comment.
Future issue: does this + eval deserve to be updated to mention continuations?
Contributor
Author
There was a problem hiding this comment.
This was referenced Jun 8, 2026
IridescentVoid
force-pushed
the
feat_new_thoths
branch
from
June 10, 2026 21:33
2f8cd4c to
5d2cb57
Compare
Contributor
Author
|
Edit: No longer relevant. |
object-Object
approved these changes
Jun 11, 2026
object-Object
left a comment
object-Object
left a comment
Member
There was a problem hiding this comment.
LGTM with two nits, though there are some merge conflicts to resolve now
IridescentVoid
force-pushed
the
feat_new_thoths
branch
from
June 15, 2026 07:16
b8c0186 to
27e727e
Compare
Contributor
Author
|
I would like to modify/add Ancient Cyphers to better demonstrate Thoth's Gambit. Currently all three use |
Contributor
|
A magnet spell could be reasonable. Capture the player's position on the stack, then loop over entities? |
Robotgiggle
force-pushed
the
feat_new_thoths
branch
from
July 19, 2026 02:54
a4a651e to
941bdde
Compare
Robotgiggle
enabled auto-merge
July 19, 2026 03:05
s5bug
pushed a commit
to s5bug/HexMod
that referenced
this pull request
Jul 26, 2026
…lingColors#1132) Closes FallingColors#1124 Depends on FallingColors#1106. May break addons, but we have no ABI guarantees for 1.21 currently. --------- Co-authored-by: Robotgiggle <88736742+Robotgiggle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a number of changes to Thoth's Gambit:
data, codein that order.Closes #1091
Closes #385