feat: block type comparison patterns - #1224
Open
IridescentVoid wants to merge 3 commits into
Open
Conversation
Member
|
As suggested by @abilliontrillionstars on discord, the basic one could be Surveyor's Distillation, which was the name used for the block comparison pattern in 1.18-era Hexal. For the strict comparison, I propose the name Inspector's Distillation. |
IridescentVoid
marked this pull request as ready for review
July 31, 2026 04:33
Robotgiggle
requested changes
Jul 31, 2026
Robotgiggle
left a comment
Robotgiggle
left a comment
Member
There was a problem hiding this comment.
Putting this here so it doesn't get buried:
Robotgiggle
requested changes
Jul 31, 2026
Robotgiggle
left a comment
Robotgiggle
left a comment
Member
There was a problem hiding this comment.
I think the descriptions for the block comparison patterns could be clarified a little to specify that they're comparing the blocks located at the two vectors, rather than the vectors themselves. This is particularly notable for Inspector's Distillation, which currently reads like it's just Equality Distillation but only for vectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two patterns for comparing the block type/state at given positions.