Apply the run configuration on run, and add Run with Parameters… - #20
Open
ChrisonSimtian wants to merge 1 commit into
Open
Apply the run configuration on run, and add Run with Parameters…#20ChrisonSimtian wants to merge 1 commit into
ChrisonSimtian wants to merge 1 commit into
Conversation
Wires the stored configuration into the two ways a target gets run. The inline ▶ stays silent: saved parameters are appended as arguments and secrets applied as environment variables, so the common case is one click and the configuration is simply in effect. "Run Target with Parameters…" opens an InputBox prefilled with the target and those same arguments, for a one-off tweak — an extra `--configuration Debug`, a different verbosity — without editing the saved configuration. Secrets still apply; they are not editable here, since the point of storing them in the keychain is that they never appear in a text field. runInTerminal disposes and recreates the Fallout terminal when an environment is supplied. A terminal's environment is fixed at creation, so reusing the existing one would silently run with a stale secret after a rotation — the failure would look like a bad credential rather than a stale terminal. Both commands are hidden from the command palette: they act on a tree item, and invoking them without one does nothing. Closes #14 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ChrisonSimtian
force-pushed
the
feature/run-config-secrets
branch
from
August 14, 2026 23:50
6975a61 to
f9e9693
Compare
ChrisonSimtian
force-pushed
the
feature/apply-run-config
branch
from
August 14, 2026 23:50
68ead92 to
82391fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6/6 of the #2 split. Closes #14. Based on #19 — the last of the stack.
Wires the stored configuration into the two ways a target gets run.
--configuration Debug, a different verbosity — without editing the saved configuration. Secrets still apply but are not editable here: the point of keychain storage is that they never appear in a text field.The subtle one
runInTerminaldisposes and recreates the Fallout terminal when an environment is supplied:A terminal's environment is fixed at creation. Reusing the existing one would silently run with a stale secret after a rotation, and the failure would present as a bad credential rather than a stale terminal — an expensive thing to debug. The no-env path still reuses the terminal, so ordinary runs don't churn it.
Both commands are hidden from the command palette: they act on a tree item, and invoking them without one does nothing.
After this merges
#2can close, and #1 (populate parameters and secrets from the build's declarations, blocked onFallout-build/Fallout#499) is the remaining follow-up.🤖 Generated with Claude Code