[Backport / 10.4]: Fix description of --no-logo option - #631
Merged
ChrisonSimtian merged 2 commits intoAug 13, 2026
Merged
Conversation
Cover the descriptions --help prints and .fallout/build.schema.json embeds. Two fail: --no-logo still describes the NUKE logo. Part of Fallout-build#553 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 3a46818)
The parameter description and its doc comment still named NUKE after the rebrand, so --help and the generated .fallout/build.schema.json told consumers the flag hides the NUKE logo. Regenerate the checked-in schema and update the four SchemaUtilitySpecs snapshots plus the inline expectation in CompletionUtilitySpecs, all of which embed the description. Closes Fallout-build#553 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit c14512d)
ChrisonSimtian
approved these changes
Aug 13, 2026
ChrisonSimtian
left a comment
ChrisonSimtian
left a comment
Collaborator
There was a problem hiding this comment.
thanks for backporting, can you version bump please as this is the first fix for this release?
ChrisonSimtian
added
Can Merge
Contributor
Author
|
No |
Collaborator
all good, I just merge it and raise a dedicated bump for the next patch release :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally closes #553 for 10.4