fix: thread-safe pam.authenticate() (#40) - #71
Merged
Conversation
Stop reusing a process-global PamAuthenticator (issue #40) and load libpam ctypes bindings once so high-QPS parallel auth stays performant. Co-authored-by: Cursor <cursoragent@cursor.com>
Disable not-callable for symbols assigned in _ensure_libs, and fix import grouping / return-statement noise so CI fail-under=8.0 passes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PamAuthenticatorinpam.authenticate()so concurrent callers no longer race onhandle(segfault /ctypes.ArgumentError).Closes #40
Test plan
poetry run pytest tests/ -q(54 passed)scratch/issue40_threaded.py --mode both— 2880/2880 ok for bothpam.authenticate()and fresh instances (previously shared mode segfaulted)Made with Cursor