document urls value for include param in credential search#225
Merged
Conversation
bendoyon
requested review from
aaparent,
aviau,
ihassanein,
ireydiak and
xvaier
as code owners
bendoyon
force-pushed
the
document-urls-include-param
branch
from
bdd655b to
b24e87f
Compare
ihassanein
previously approved these changes
Jul 3, 2026
Adds the `urls` option to the `include` parameter for the ASTP Search Credentials endpoint (up to 100 full URLs per credential; `auth_domains` reports the host portion). Also corrects the `auth_domains` limit (10 -> 100). The `include` param is decoupled from the shared common snippet so each endpoint documents its own options in place: `urls` is not offered on the firework Global Search endpoint (its response mapping drops the field). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bendoyon
force-pushed
the
document-urls-include-param
branch
from
b24e87f to
d9283fe
Compare
ihassanein
dismissed
their stale review
There are other changes that need to be made that were not initially caught
ihassanein
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
urlsoption to theincludeparameter for the firework v4 Global Search and ASTP credential search endpoints.Before changes (ASTP):
After changes (ASTP):
Changelog:
