Limit the number of returned access technology settings#209
Merged
Conversation
Respect the maximum list size of eRDX configurations
cookpate
approved these changes
Jun 29, 2026
cookpate
previously approved these changes
Jul 2, 2026
AniruddhaKanhere
previously approved these changes
Jul 2, 2026
AniruddhaKanhere
left a comment
AniruddhaKanhere
left a comment
Member
There was a problem hiding this comment.
LGTM. Approved!
NIT: can we also add an assert to this line like so: assert( count < CELLULAR_EDRX_LIST_MAX_SIZE );
This should never be called with more than the maximum configured count. Assert if it somehow is
kstribrnAmzn
dismissed stale reviews from AniruddhaKanhere and cookpate
via
53a96f3
Member
Author
|
@AniruddhaKanhere updated to add the assertion. |
AniruddhaKanhere
approved these changes
Jul 2, 2026
rawalexe
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Respect the maximum list size of eRDX configurations.
In the case of a cellular modem returning more eRDX settings through the
AT+CEDRXS?query, the current library would write out of bounds. This would only happen in two cases:CELLULAR_EDRX_LIST_MAX_SIZEmacrosTest Steps
Unit test added
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.