Refactor settings into product domains#799
Draft
FuJacob wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Group Cotabby's durable suggestion settings into subsystem-owned domain values while preserving the existing SwiftUI properties, generation snapshot, and flat persistence keys. This gives future work cohesive settings boundaries without making a migration part of the refactor.
This is the third PR in the repository-organization stack and is based on #798.
Validation
swiftlint lint --strict— 0 violations.xcodegen generate— succeeded and the generated project is committed.xcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build-for-testing -derivedDataPath build/DerivedData— TEST BUILD SUCCEEDED.SuggestionSettingsDataproperties remain as bidirectional forwarding accessors.Linked issues
None.
Risk / rollout notes
No UserDefaults or Keychain key changes are included.
SuggestionSettingsSnapshotretains its existing shape and the observable model retains its individual@Publishedproperties, so this should not alter persistence, observation timing, or generation behavior.