web(StreamProgressBar): clamp progress percentage between 0 and 100 - #583
Conversation
…ssBar - Ensured all percentage calculations are clamped with Math.min(100, Math.max(0, val)) to prevent values exceeding 100% for completed streams - Applied clamping consistently to remainingPercent and the vested display label Closes Fundable-Protocol#413
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPayment stream UI updates refresh countdown time immediately and clamp remaining and vested percentages to prevent values outside the 0–100 range. ChangesPayment stream display corrections
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Abdul-dev-creator Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/components/modules/payment-stream/StreamProgressBar.tsx`:
- Line 145: Update the vested percentage expression in StreamProgressBar so
zero, non-finite, or otherwise invalid stats.total values are handled before
division and formatting. Ensure the label always renders a valid clamped
percentage, including the invalid-input fallback, while preserving the existing
one-decimal format.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 00f783fe-71be-4177-bf12-45e4c02e3c07
📒 Files selected for processing (2)
apps/web/src/components/modules/payment-stream/StreamCountdown.tsxapps/web/src/components/modules/payment-stream/StreamProgressBar.tsx
| <div className="flex justify-between items-center text-[10px] text-zinc-400 font-mono"> | ||
| <span>{stats.withdrawnPercent.toFixed(1)}% withdrawn</span> | ||
| <span>{((stats.vestedSize / stats.total) * 100).toFixed(1)}% vested</span> | ||
| <span>{Math.min(100, Math.max(0, (stats.vestedSize / stats.total) * 100)).toFixed(1)}% vested</span> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Handle invalid totals before formatting the vested label.
The invalid-input fallback returns total: 0 and vestedSize: 0, so this expression evaluates to NaN. Math.min/Math.max preserve NaN, causing the UI to render NaN% vested instead of a clamped value.
Proposed fix
- <span>{Math.min(100, Math.max(0, (stats.vestedSize / stats.total) * 100)).toFixed(1)}% vested</span>
+ <span>{(stats.total > 0
+ ? Math.min(100, Math.max(0, (stats.vestedSize / stats.total) * 100))
+ : 0
+ ).toFixed(1)}% vested</span>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <span>{Math.min(100, Math.max(0, (stats.vestedSize / stats.total) * 100)).toFixed(1)}% vested</span> | |
| <span>{(stats.total > 0 | |
| ? Math.min(100, Math.max(0, (stats.vestedSize / stats.total) * 100)) | |
| : 0 | |
| ).toFixed(1)}% vested</span> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/web/src/components/modules/payment-stream/StreamProgressBar.tsx` at line
145, Update the vested percentage expression in StreamProgressBar so zero,
non-finite, or otherwise invalid stats.total values are handled before division
and formatting. Ensure the label always renders a valid clamped percentage,
including the invalid-input fallback, while preserving the existing one-decimal
format.
b48348e to
ec45835
Compare
1 participant
Overview
This PR clamps the progress percentage values in StreamProgressBar to [0, 100] to prevent the bar from displaying > 100% for completed streams or under edge cases.
Related Issue
Closes #413
Changes
Math.min(100, Math.max(0, val))clamping toremainingPercentfor consistencyMath.min(100, Math.max(0, val))clamping to the vested percentage display label to prevent values exceeding 100%Verification
Summary by CodeRabbit