feat: consolidate contract address definitions into single configuration source && feat: add ARIA labels to cancellation info tooltips - #586
Conversation
|
@0xElyte Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughContract identifiers are consolidated in ChangesContract configuration consolidation
Payment stream status accessibility
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #376
web(constants): consolidate contract address definitions into single configuration source
Summary
PAYMENT_STREAM_CONTRACT_ID and DISTRIBUTOR_CONTRACT_ID are exported from both constants.ts and env.ts, leading to import ambiguity across components.
Acceptance criteria
All components import contract addresses from unified config @/lib/env.
Closes #402
web(PaymentStreamSummary): add ARIA labels to cancellation info tooltips
Summary
Info icons lack aria-label attributes for screen readers.
Acceptance criteria
Issue is resolved in apps/web/src/components/modules/payment-stream/PaymentStreamSummary.tsx:40-65.
No regression introduced in existing test suites.
Summary by CodeRabbit