feat: Introduce full tensor permeability by CusiniM · Pull Request #2822 · GEOS-DEV/GEOS

CusiniM · 2023-11-15T00:47:06Z

@castelletto1 should be usable but I have not tested it yet.

castelletto1 · 2023-11-27T20:28:52Z

I confirm it works. I ran an incompressible single-phase flow quarter five spot problem without gravity on two domains. The first case, the domain is aligned with the Cartesian axes and the permeability tensor is diagonal. In the second case, the domain is obtained by rotating the aligned domain and consistently updating the permeability tensor, which becomes full tensor. In both cases the grid is K-orthogonal and TPFA is correct. The computed Jacobian matrices are the same. Below two snapshots with details for the same cell (Id 52) in both domains.

I temporarily added xml and vtk files to reproduce the results in ./inputFiles/singlePhaseFlow/fullTensorPermeability
We may end up adding a new smoke test.

@karimifard, @jafranc, @francoishamon: have a look and share if you think this is headed in the correct direction.

jafranc · 2023-11-28T15:28:08Z

-      m_permeability[ei][q][1] =  m_permeabilityComponents[1];
-      m_permeability[ei][q][2] =  m_permeabilityComponents[2];
+      for ( int c=0; c < 6; c++)
+      m_permeability[ei][q][c] =  m_symmetricFullPermeabilityTensor[c];


Shouldn't we enforce positiveness of diagonal component here ?

We should really throw an error earlier if someone inputs a negative value but, for now, I am using the default negative value to distinguish whether a diagonal or a full tensor was provided so I need to improve that logic fist.

One option would be to simply provide 2 R1Tensors one for the main diagonal and one for the off diagonal terms and have the off diagonal components default to 0.0 if not provided.

Just noticed that the order would be imposed by LvArray::Ri_eq_symAijBj implicitly :/

yes, and it's different from the one used by vtk.

jafranc · 2023-11-28T16:04:35Z

+    LvArray::tensorOps::Ri_eq_symAijBj< 3 >( faceConormal, coef, faceNormal );
    weight = LvArray::tensorOps::AiBi< 3 >( cellToFace, faceConormal );
+    // Matteo: this one also has to change! 
    LvArray::tensorOps::hadamardProduct< 3 >( dWeight_dCoef, cellToFace, faceNormal );


I am not sure about how this one should change.

#2822 (comment)

This should be addressed first

@castelletto1 do you know how it should be changed?

jafranc · 2023-11-28T16:11:58Z

I confirm it works. I ran an incompressible single-phase flow quarter five spot problem without gravity on two domains. The first case, the domain is aligned with the Cartesian axes and the permeability tensor is diagonal. In the second case, the domain is obtained by rotating the aligned domain and consistently updating the permeability tensor, which becomes full tensor. In both cases the grid is K-orthogonal and TPFA is correct. The computed Jacobian matrices are the same. Below two snapshots with details for the same cell (Id 52) in both domains.

I temporarily added xml and vtk files to reproduce the results in ./inputFiles/singlePhaseFlow/fullTensorPermeability We may end up adding a new smoke test.

@karimifard, @jafranc, @francoishamon: have a look and share if you think this is headed in the correct direction.

I let @karimifard and @francoishamon, who are more expert than I am, tell if it is what they had in mind.
It looks like a right start and not adding too much complexity. There will be some bookkeeping traps along the road though and I like @CusiniM 's idea to have one tensor for the diag and one for off-diag so the full tensor case is use as the base and off-diag zeroed out by default.

…llTensorPerm

…GEOS into feature/cus-cas/fullTensorPerm

# Conflicts: # src/coreComponents/finiteVolume/CellElementStencilTPFA.hpp

paveltomin · 2025-08-08T21:07:05Z

@castelletto1 can we just merge this?

rrsettgast · 2026-07-20T23:38:15Z

@copilot resolve the merge conflicts in this pull request

Copilot · 2026-07-20T23:42:11Z

@copilot resolve the merge conflicts in this pull request

Resolved. I merged develop into this branch and fixed the conflicts in src/coreComponents/constitutive/permeability/CarmanKozenyPermeability.cpp and src/coreComponents/constitutive/permeability/ConstantPermeability.hpp in commit 13ceacd.

CusiniM and others added 2 commits November 14, 2023 16:45

boundary stencil

b8f4c46

Merge branch 'develop' into feature/cus-cas/fullTensorPerm

ea3fd3b

CusiniM commented Nov 15, 2023

View reviewed changes

Comment thread src/coreComponents/finiteVolume/BoundaryStencil.hpp Outdated

CusiniM and others added 2 commits November 15, 2023 08:18

missing ;

638a410

it compiles

b740ec4

CusiniM commented Nov 17, 2023

View reviewed changes

Comment thread src/coreComponents/constitutive/permeability/ConstantPermeability.cpp Outdated

Full tensor permebility test

eb1fa9a

jafranc added the spe11 spe11-required-feature label Nov 28, 2023

jafranc reviewed Nov 28, 2023

View reviewed changes

CusiniM and others added 3 commits March 13, 2024 10:16

Merge remote-tracking branch 'origin/develop' into feature/cus-cas/fu…

ce54941

…llTensorPerm

Merge branch 'feature/cus-cas/fullTensorPerm' of github.com:GEOS-DEV/…

5274772

…GEOS into feature/cus-cas/fullTensorPerm

Merge branch 'refs/heads/develop' into feature/cus-cas/fullTensorPerm

5a10e64

# Conflicts: # src/coreComponents/finiteVolume/CellElementStencilTPFA.hpp

CusiniM changed the title ~~Introduce full tensor permeability~~ feat: Introduce full tensor permeability Jul 8, 2024

Merge branch 'develop' into feature/cus-cas/fullTensorPerm

a9314e2

rrsettgast assigned CusiniM Dec 17, 2024

rrsettgast marked this pull request as ready for review December 17, 2024 18:15

rrsettgast requested review from castelletto1, dkachuma, jhuang2601, paveltomin, rrsettgast and ryar9534 as code owners December 17, 2024 18:15

castelletto1 added 2 commits December 20, 2024 08:00

Post merge fixes

e4c929a

Post merge fixes

cc53d0d

paveltomin approved these changes Feb 1, 2025

View reviewed changes

paveltomin added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Aug 8, 2025

Merge branch 'develop' into feature/cus-cas/fullTensorPerm

5623c91

paveltomin removed the request for review from ryar9534 August 8, 2025 19:55

Pavel Tomin and others added 3 commits August 8, 2025 15:53

code style

57c3d8e

build fix

ced159d

Update ConstantPermeability.cpp

a5a0810

Copilot started work on behalf of rrsettgast July 20, 2026 23:38 View session

Merge origin/develop into feature/cus-cas/fullTensorPerm

13ceacd

Copilot AI requested review from OmarDuran and bd713 as code owners July 20, 2026 23:42

Copilot finished work on behalf of rrsettgast July 20, 2026 23:42

rrsettgast added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jul 21, 2026

Uh oh!

Conversation

CusiniM commented Nov 15, 2023

Uh oh!

Uh oh!

Uh oh!

castelletto1 commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jafranc commented Nov 28, 2023

Uh oh!

paveltomin commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rrsettgast commented Jul 20, 2026

Uh oh!

Copilot AI commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

castelletto1 commented Nov 27, 2023 •

edited

Loading

paveltomin commented Aug 8, 2025 •

edited

Loading