[wip] refact: Fit ALM as LM in the Poromechanics hierarchy#4101
Draft
jafranc wants to merge 3 commits into
Draft
[wip] refact: Fit ALM as LM in the Poromechanics hierarchy#4101jafranc wants to merge 3 commits into
jafranc wants to merge 3 commits into
Conversation
- normalizing ALMSinglePhase to be a PoromechanicsConformingFractures and not a SinglePhasePoromechanics anymore (as done for LM) - moving up `faceNodalArea` and `faceIntegral` to ContactSolverBase - moving up constexpr maxNumNodes - temp patching `hasStabilization/getStabilizationName` while waiting for bubble to reframe as Stabilization
jafranc
requested review from
OmarDuran,
castelletto1,
frankfeifan,
jhuang2601 and
rrsettgast
as code owners
July 23, 2026 08:39
jafranc
changed the title
jafranc
marked this pull request as draft
July 23, 2026 08:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is proposal to refacttor ALM as a Contact policy for
Poromechanicsclasss to restrict code duplicaitonMake MGR/Sequential support clear and loud:
GEOS_MGR_STRATEGY_NOT_SUPPORTED()MACRO to avoid code duplication while being temporary (until proper recipe is implemented and tested) [left aside SinglePhaseReservoirAndWells, CoupledReservoirAndWellsBase to focus on ALM]forceSequential()to be explicit about this (also temporary) traits of this class [could be extended to PhaseField Models]Fit ALM in PM hierarchy:
faceNodalAreaandfaceIntegralto ContactSolverBasehasStabilization/getStabilizationNamewhile waiting for bubble to reframe as StabilizationMake Bubble a stabilization in ALM Contact
Warning
WIP - Proposal - DO NOT MERGE