fix(llc): reduce default thread participant and member limits#2822
fix(llc): reduce default thread participant and member limits#2822VelikovPetar wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesThreadOptions defaults
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
+ Coverage 71.28% 71.29% +0.01%
==========================================
Files 430 430
Lines 26934 26934
==========================================
+ Hits 19199 19202 +3
+ Misses 7735 7732 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Submit a pull request
Linear: FLU-595
Github Issue: #
CLA
Description of the pull request
Reduces the default
participantLimitandmemberLimitonThreadOptionsfrom100to10, cutting data usage when querying threads. These defaults apply toStreamChatClient.queryThreads/getThreadand, transitively, toStreamThreadListController.Context:
ThreadListQuery.participantLimitdefaults to10(verified againststream-chat-swiftdevelop). iOS has nomember_limiton the thread query at all; Flutter keeps the field and lowers its default to10.replyLimitis left unchanged at2(already stricter than iOS's3).StreamUserAvatarStack(max: 3)) and no thread members, so there is no visible change by default. The message-list thread footer usesmessage.threadParticipants(a separateMessagefield), which is unaffected.Not a source-breaking change (no signatures change). Callers relying on the old counts can pass an explicit
ThreadOptions(participantLimit: 100, memberLimit: 100).Test instructions:
cd packages/stream_chat && dart test test/src/core/api/requests_test.dart— added aThreadOptionsgroup covering default and explicit serialization.Screenshots / Videos
No UI changes.
Summary by CodeRabbit
Changes
Tests