Variant Configs & Sweep Tools - #6901
Open
george-kalisse-sada wants to merge 1 commit into
Open
Conversation
george-kalisse-sada
force-pushed
the
SADA_4_configs_sweep_tools
branch
from
August 5, 2026 17:45
3b6a9ef to
9345124
Compare
|
/cc @pmandewalkar |
pmandewalkar
reviewed
Aug 8, 2026
| return sorted(all_metrics) | ||
|
|
||
|
|
||
| def get_median(values): |
There was a problem hiding this comment.
nit: i see that in sweep.py we import statistics and use that median, is there a reason why that's being redefined here?
pmandewalkar
reviewed
Aug 8, 2026
| f"kubectl delete sandboxclaims --all -n {namespace} --ignore-not-found=true", | ||
| check=False, | ||
| ) | ||
| for _ in range(100): |
There was a problem hiding this comment.
Can we use the built in kubernetes wait function here?
pmandewalkar
reviewed
Aug 8, 2026
pmandewalkar
left a comment
pmandewalkar
left a comment
There was a problem hiding this comment.
I see a good amount of YAML duplication across configs like baseline.yaml, c4a_arm.yaml, c4d_amd.yaml, larger_vm.yaml, etc., with mostly identical benchmark definitions. I think for overall easier maintenance and longevity could we use templating similar to how it is done in sched_tuner_daemonset.yaml.j2?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files: ~20 new files
perfkitbenchmarker/data/k8s_agents/config/agentic_benchmark_config.yamlperfkitbenchmarker/data/k8s_agents/config/variants/baseline.yamlperfkitbenchmarker/data/k8s_agents/config/variants/kubelet_pulls.yamlperfkitbenchmarker/data/k8s_agents/config/variants/overlay_none.yamlperfkitbenchmarker/data/k8s_agents/config/variants/larger_vm.yamlperfkitbenchmarker/data/k8s_agents/config/variants/hyperdisk_200gb.yamlperfkitbenchmarker/data/k8s_agents/config/variants/thp.yamlperfkitbenchmarker/data/k8s_agents/config/variants/sched_tuning.yamlperfkitbenchmarker/data/k8s_agents/config/variants/swap.yamlperfkitbenchmarker/data/k8s_agents/config/variants/c4d_amd.yamlperfkitbenchmarker/data/k8s_agents/config/variants/c4a_arm.yamlperfkitbenchmarker/data/k8s_agents/config/variants/multi_node.yamlperfkitbenchmarker/data/k8s_agents/config/variants/variant_reference_guide.mdperfkitbenchmarker/data/k8s_agents/config/variants/tuning/kubelet_parallel_pulls.yamlperfkitbenchmarker/data/k8s_agents/config/variants/tuning/sched_tuner_daemonset.yaml.j2perfkitbenchmarker/data/k8s_agents/config/variants/tuning/swap_config.yamlperfkitbenchmarker/data/k8s_agents/config/variants/tuning/thp_config.yamlperfkitbenchmarker/scripts/agentic/sweep.pyperfkitbenchmarker/scripts/agentic/analyze.py.gitignoreadditionsDescription: Adds optimization sweep infrastructure:
k8s_snapshotkey including--enable-pod-snapshotsingke_additional_flags.agentic_benchmark_config.yaml) with YAML anchors for consistent cluster definitionssweep.py) — orchestrates multi-variant benchmark sweeps across all 7 benchmarks with warm pool drain between sweep levelsanalyze.py) — parses PKB NDJSON results, computes deltas vs baseline, generates markdown reports and CSV exports. Supports all 7 benchmarks via registry with auto-discovery fallback.