fix a bug in type hashconsing#103
Open
deyaaeldeen wants to merge 2 commits into
Open
Conversation
deyaaeldeen
force-pushed
the
fix-hashcons
branch
2 times, most recently
from
April 8, 2020 14:14
dc2a7a6 to
26c895a
Compare
deyaaeldeen
marked this pull request as ready for review
April 8, 2020 14:18
deyaaeldeen
force-pushed
the
fix-hashcons
branch
from
April 8, 2020 16:26
26c895a to
e131cd0
Compare
akuhlens
approved these changes
Apr 8, 2020
| (Types-hashcons! #t (Type -> Type)) | ||
| (Types-gen-index! #t (Type -> Unit)) | ||
| (Types-gen-index! #t (-> Unit)) | ||
| (get-types-hashcons-index #f (-> Int)) |
Collaborator
There was a problem hiding this comment.
Is this left in by mistake?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index field in types was not being updated correctly. Before the fix, 0 was written to the index field, regardless of the current value of
types_unique_index_counter, becauseTypes-gen-index!has side effects and its result is not written to the variable.Furthermore, I decreased some code bloat by taking advantage of uniform memory layout of structural types.
Finally, I fixed a memory leak when resizing the types hashconsing table.