fix(diagnostics): classify external import edges#2132
Draft
cgoulart21 wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imports_from -> ref_*edges separatelyfrom malformed internal endpoints
external_import_edgesdiagnostic count and explain it in thetext report
internal edge visible
Closes #2130.
Root cause
The JavaScript/TypeScript resolver deliberately namespaces unresolved external
packages as
ref_*so they cannot alias onto unrelated in-corpus nodes. Thebuilder intentionally drops those out-of-corpus edges, but
diagnose_extraction()categorized every absent endpoint as dangling. This madeexpected dependency evidence indistinguishable from corrupt internal edges.
Validation
pytest tests/test_multigraph_diagnostics.py tests/test_phantom_external_import.py tests/test_ts_import_require.py -qruff check graphify/diagnostics.py tests/test_multigraph_diagnostics.pypyright --pythonpath .venv/Scripts/python.exe graphify/diagnostics.py tests/test_multigraph_diagnostics.pyassumptions, sandboxed global install paths, and optional OpenAI dependency)