Skip to content

Fix fragmented protected requests over Serial HDLC #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefan-andrejevic wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −4
Open

Fix fragmented protected requests over Serial HDLC #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35946ff
fix(hdlc): preserve generated transport frame sequences
Aug 6, 2026
16daa9a
fix(reader): preserve reply state across fragmented frames
Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Gurux.DLMS.Client.Example.python/GXDLMSReader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ def readDLMSPacket(self, data, reply=None):
self.readDLMSPacket2(data, reply)
elif data:
for it in data:
reply.clear()
self.readDLMSPacket2(it, reply)

def readDLMSPacket2(self, data, reply):
Expand Down Expand Up @@ -228,7 +227,6 @@ def readDataBlock(self, data, reply):
if data:
if isinstance(data, (list)):
for it in data:
reply.clear()
self.readDataBlock(it, reply)
return reply.error == 0
else:
Expand Down
4 changes: 3 additions & 1 deletion Gurux.DLMS.python/gurux_dlms/GXDLMS.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,9 @@ def receiverReady(cls, settings, reply):
None,
)
reply = GXDLMS.getSnMessages(p)
return reply[0]
# Protected next-block requests can span multiple HDLC frames.
# Return the full frame list so the caller can transmit every frame.
return reply

#
# Reserved for internal use.
Expand Down
2 changes: 1 addition & 1 deletion Gurux.DLMS.python/gurux_dlms/GXDLMSClient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ def getObjectsRequest(self):
name = "0.0.40.0.0.255"
else:
name = int(0xFA00)
return self._read(name, ObjectType.ASSOCIATION_LOGICAL_NAME, 2)[0]
return self._read(name, ObjectType.ASSOCIATION_LOGICAL_NAME, 2)

def method(self, item, index, data, type_):
return self.__method(item.name, item.objectType, index, data, type_)
Expand Down