Refactor: ModDownloadListPageSkin#6375
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the search panel layout in DownloadListPage.java from a GridPane to a VBox with collapsible HBox rows, introducing an expand/collapse toggle button for advanced search options. The review feedback highlights a bug where nested buttons are created when updating the toggle button's graphic, as well as redundant GridPane.setHgrow layout constraints applied to the new HBox rows inside the VBox container.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the search pane layout in DownloadListPage from a GridPane to a VBox containing nested HBox rows. It introduces an expandable layout where advanced search options (like game version, category, and sorting) are placed in a secondary row that can be toggled via an expand button. Additionally, various layout properties, such as preferred widths and alignments, have been adjusted to accommodate this new structure. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
建议“名称”和“游戏”互换位置，以及把这个类重命名为 |
个人建议不要随便 at 人，除非你是本 pr 作者想申请他人 review
要这样的话如果我翻了半天发现没有我想要的模组还得重新翻回去，有点麻烦。MC百科那个是因为屏幕比较大，不需要太多滚动，所以能这么干，HMCL则不行
这样更麻烦
现在不就是这样吗
其实这样不如本PR现在的情况（ |
彳亍
为什么不整个"回到顶部"按钮呢
没多大问题吧
是吗? 这不还是一整块在这上面? 我的意思是像Github这样
上面有个title这里的title写得是分类(而不是一整块)
|
|
我感觉修改后没有原来的直观。右边只有一个小三角，并没有告知作用是什么。不对齐的格子也有点诡异 |
我记得之前有人提过要再加一个面板项目的，这样凑成 3x2 的应该会好很多 |
哦哦哦，懂了。但还是感觉没啥意义（ |
个人感觉挺好 |
4 participants
重构了
ModDownloadListPageSkin分类和排序使用，游戏和名称应该才是最频繁使用的。实况