Skip to content

NW 46260: Fixes TypeError when trying to access feed url#10712

Open
aaronbidzan wants to merge 1 commit into
ILIAS-eLearning:release_11from
aaronbidzan:nw/11/46260
Open

NW 46260: Fixes TypeError when trying to access feed url#10712
aaronbidzan wants to merge 1 commit into
ILIAS-eLearning:release_11from
aaronbidzan:nw/11/46260

Conversation

@aaronbidzan

@aaronbidzan aaronbidzan commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

This PR attempts to fix https://mantis.ilias.de/view.php?id=46260.

Calls legacy entry_point for feed and private news feed.

@thojou

Kind regards,
@bidzanaaron

@thojou thojou self-assigned this Dec 15, 2025
@thojou thojou added bugfix php Pull requests that update Php code labels Dec 15, 2025
@thojou thojou mentioned this pull request Dec 15, 2025
Open
@thojou thojou requested a review from kergomard December 15, 2025 13:37
@thojou

thojou commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Hey @kergomard,

we've fixed a strlen call with null issue inside the user object.
Could you please have a quick look, thanks :)

@matheuszych

matheuszych commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Hey @thojou , Hey @bidzanaaron ,

this fix seems also to resolve the issue https://mantis.ilias.de/view.php?id=46982 .

Best regards
@matheuszych

kergomard
kergomard approved these changes Jan 26, 2026
View reviewed changes

@kergomard kergomard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @bidzanaaron , sorry I missed this so long, and thanks to @dsstrassner for pointing me to it!

Changes in the user are ok with me.

Best,
@kergomard

@thojou

thojou commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Hey @alex40724,

Could you take a quick look at the changes made inside the feed component?
If everything looks good, I will proceed with the merge.

Thanks alot.
Best Regards,
@thojou

@thojou thojou requested a review from alex40724 February 24, 2026 11:52
@oliversamoila

oliversamoila commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Hey @alex40724,
the test case associated with this issue is marked as a 'Blocker' in TestRail. It would be great if you could take a look at your components.
Thanks in advance.

Best regards,
@thojou and @oliversamoila

@fab-kru

fab-kru commented Apr 23, 2026

Copy link
Copy Markdown

+1 for getting this one out of the way. Would be good to get this fix for 11.0 stable.

@aaronbidzan
User: Fix Feed Hash Null Error
a2362c5 
See: https://mantis.ilias.de/view.php?id=46260

Changed the check in `ilObjUser::getFeedHash()` to use
`$rec['feed_hash'] ?? ''` instead of `$rec['feed_hash']` before
calling `strlen()`, so a `null` value no longer causes an error.
@aaronbidzan

aaronbidzan commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Entry point changes have been reverted, and only the hash fix is applied in this PR. Entry point changes have been implemented simultaneously with a6f6d87 by Alex.

Kind regards,
@aaronbidzan

@aaronbidzan aaronbidzan changed the title NW 46260: Calls legacy entry_point for feed and private news feed NW 46260: Fixes TypeError when trying to access feed url Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kergomard kergomard kergomard approved these changes
@alex40724 alex40724 Awaiting requested review from alex40724

Assignees

@thojou thojou

Labels

bugfix php Pull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aaronbidzan @thojou @matheuszych @oliversamoila @fab-kru @kergomard