[FEATURE] UI: add Column\Listing component#11728
Open
thibsy wants to merge 1 commit into
Open
Conversation
thibsy
added
kitchen sink
improvement
php
Introduces a new `UI\Component\Table\Column\Listing` component, which accepts an `UI\Component\Listing\Unordered` or `…\Ordered` component. To keep rows consistent a expand/collapse mechanism was put in place, truncating list items at some point if used inside a table column. This makes the `UI\Component\Table\Column\LinkListing` component obsolete, which has been removed during this process. Usages in ILIAS were updated to use the new listing component instead. Co-authored-by: Thibeau Fuhrer <thibeau@sr.solutions>
thibsy
force-pushed
the
feature/12/ui-listing-column
branch
from
6cf859a to
6634520
Compare
Contributor
Author
|
@oliversamoila this should be good to go now, I added the JF label to confirm the interface at JF and notify about the possible breaking changes (removal of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, this
Introduces a new
UI\Component\Table\Column\Listingcomponent, which accepts anUI\Component\Listing\Unorderedor…\Orderedcomponent. To keep rows consistent a expand/collapse mechanism was put in place, truncating list items at some point if used inside a table column.This makes the
UI\Component\Table\Column\LinkListingcomponent obsolete, which has been removed during this process. Usages in ILIAS were updated to use the new listing component instead.This supersedes #9522 and takes over the work on behalf of @kergomard during his absence.
Kind regards,
@thibsy