Reject non-finite flux-summary numerics - #273
Draft
FlorianPfaff wants to merge 4 commits into
Draft
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
summarize_flux()timing metadata before computing scientific summariesbeltmap-flux-summaryrejectNaN/infinite frame rates during argument parsing, before writing artifactsRoot cause
beltmap-flux-summaryparsed--frame-rate-hzwith plainfloat(). Comparisons such asnan <= 0are false, soNaNwas forwarded tosummarize_flux()instead of being treated as absent or invalid.The shared summarizer also accepted non-finite timing metadata directly. It stores
frame_rate_hzin the result and multiplies per-frame velocities by it, soNaN, infinity, or finite arithmetic overflow could reachparticle_flux_summary.jsonas bareNaN/Infinitytokens. Python's encoder permits those by default, but they are not valid strict JSON and can also make the reported science metrics meaningless.Impact
Malformed timing metadata now fails clearly rather than producing non-standard JSON or non-finite velocity/flux statistics. Normal finite inputs and the CLI's existing zero-as-unspecified behavior are unchanged.
Validation
NaNframe ratesmainGitHub Actions will provide the repository-wide test and lint result.