Fix revolution labels for shifted phase anchors - #293
Draft
FlorianPfaff wants to merge 3 commits into
Draft
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
BeltMotionModel.reference_frameand velocity signRoot cause
belt_revolution_indices()computed traveled distance asabs(velocity * (frame - reference_frame)).reference_frameis an anchor for the phase equation, not the start of the processed sequence. With a nonzero reference frame, the resulting revolution IDs decrease toward the anchor and then increase again, so physically distinct passes can receive the same label.Impact
Recurrent-artifact maps and train/evaluation revolution splits can merge different physical belt passes whenever callers use an equivalent motion model anchored at a nonzero frame. The fix produces chronological labels starting at zero while preserving the existing output for the default
reference_frame=0case.Validation
python -m py_compile[0, 0, 0, 0, 1, 1, 1, 2], matching the equivalent frame-0 anchor