Make replacedimnames a no-op for an empty replacement set#216
Merged
Conversation
`replacedimnames`, and `replaceinds` which delegates to it, now return the tensor unchanged when given no replacement pairs instead of throwing. Base's `replace(::AbstractArray)` with no pairs errors with `promote_valuetype()`, unlike `replace(::AbstractString)` which returns the string, so the empty case has to be short-circuited explicitly. This lets callers pass a computed, possibly-empty set of relabelings without guarding the empty case themselves.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 75.99% 76.00% +0.01%
==========================================
Files 30 30
Lines 1683 1684 +1
==========================================
+ Hits 1279 1280 +1
Misses 404 404
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replacedimnames, andreplaceindswhich delegates to it, now return the tensor unchanged when given no replacement pairs instead of throwing. Base'sreplace(::AbstractArray)with no pairs errors withpromote_valuetype(), unlikereplace(::AbstractString)which returns the string, so the empty case has to be short-circuited explicitly. This lets callers pass a computed, possibly-empty set of relabelings without guarding the empty case themselves.