Add data for TensorKit tensor maps#206
Merged
Merged
Conversation
Adds a `TensorAlgebra.data` method for `TensorMap` and `DiagonalTensorMap` in the TensorKit extension, so `data` and `datatype` resolve for TensorKit-backed tensors. A `TensorMap` is not an `AbstractArray`, so it has no `Base.parent(::AbstractArray)` self-fallback for the generic `data` recursion to reach, and the recursion had no leaf to bottom out on. The methods route into the flat block storage vector `t.data` (type `storagetype(t)`) and keep recursing through `data`, so any wrapper on that vector is unwrapped to the true leaf. A lazy `AdjointTensorMap` already defines `Base.parent`, so the generic recursion unwraps it with no dedicated method, and a general `AbstractTensorMap` has no single storage vector, so gets no method.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 81.10% 81.14% +0.04%
==========================================
Files 24 24
Lines 905 907 +2
==========================================
+ Hits 734 736 +2
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtfishman
enabled auto-merge (squash)
July 10, 2026 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
TensorAlgebra.datamethod forTensorMapandDiagonalTensorMapin the TensorKit extension, sodataanddatatyperesolve for TensorKit-backed tensors. ATensorMapis not anAbstractArray, so it has noBase.parent(::AbstractArray)self-fallback for the genericdatarecursion to reach, and the recursion had no leaf to bottom out on. The methods route into the flat block storage vectort.data(typestoragetype(t)) and keep recursing throughdata, so any wrapper on that vector is unwrapped to the true leaf. A lazyAdjointTensorMapalready definesBase.parent, so the generic recursion unwraps it with no dedicated method, and a generalAbstractTensorMaphas no single storage vector, so gets no method.