Skip to content

feat: support MCCL on MetaX#50

Merged
Ziminli merged 4 commits into
masterfrom
feat/support-mccl-metax
Jul 15, 2026
Merged

feat: support MCCL on MetaX#50
Ziminli merged 4 commits into
masterfrom
feat/support-mccl-metax

Conversation

@Ziminli

@Ziminli Ziminli commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add MCCL backend support for MetaX by reusing the shared CCL backend abstraction. This PR adds a new src/backends/ccl/mccl backend layer, binds BackendType::kMccl to Device::Type::kMetax, and updates CMake/bridge generation so MetaX builds can discover, link, and generate code for MCCL.

The implementation follows the same provider-oriented structure as NCCL: common CCL operation implementations are reused, while the MCCL-specific API wrapper, type map, operation registration, and MetaX provider alias live under src/backends/ccl/mccl.

Changes

  • MCCL backend support

    • Add the new src/backends/ccl/mccl backend family, including the MCCL API wrapper, type mapping, checks, and operation registrations that reuse the common CCL implementation layer.
  • MetaX integration

    • Add the MetaX MCCL provider alias under src/backends/ccl/mccl/metax and mark BackendType::kMccl with Device::Type::kMetax as a supported backend/device combination.
  • Build and generation

    • Update top-level and src CMake logic to expose WITH_MCCL, discover MetaX MCCL dependencies, and link the library/examples when MCCL is enabled.
    • Update scripts/gen_bridge.py so CCL provider headers and backend implementation headers are generated for MCCL in the same pattern as NCCL.
  • Documentation and templates

    • Update README.md with MCCL backend documentation and .github/pull_request_template.md with MCCL backend checklist entries.

Platform and Backend Affected

Platform

  • CPU
  • NVIDIA GPU
  • Iluvatar GPU
  • MetaX GPU
  • Moore Threads GPU
  • Cambricon MLU

Backend

  • OpenMPI
  • MPICH
  • NCCL
  • MCCL

Performance Impact

  • No performance impact
  • Performance improved
  • Performance regression possible

N/A.

Known Issues & Future Work

  • MCCL support currently covers the CCL operations already provided by the shared CCL abstraction: GetUniqueId, CommInitRank, CommDestroy, and AllReduce.
  • DataType::kInt16 and DataType::kUInt16 are mapped as unsupported for MCCL until the backend API supports them.
  • If MetaX MCCL diverges from the assumed MCCL API surface, follow-up work should override only the divergent pieces under src/backends/ccl/mccl/metax.

Test Results

Test Involved Platform

  • CPU
  • NVIDIA GPU
  • Iluvatar GPU
  • MetaX GPU
  • Moore Threads GPU
  • Cambricon MLU

Test Involved Backend

  • OpenMPI
  • MPICH
  • NCCL
  • MCCL

MetaX with MCCL:
ccl_all_reduce.log

MetaX with MCCL+OpenMPI:
ccl_mpi_hybrid_all_reduce.log


Checklist

Every contributor must verify every item below before requesting
review. Tick each box only after the check has actually been performed —
do not tick speculatively. If an item truly does not apply, replace the
checkbox with N/A and briefly explain why in an inline comment.

Title, Branch, and Commits

  • PR title follows Conventional Commits (e.g. feat: …, fix(nccl): …).
  • Branch name follows <type>/xxx-yyyy-zzzz where <type> matches the PR title's Conventional Commits type and words are joined with hyphens (see CONTRIBUTING.md §Branches).
  • Each commit message follows Conventional Commits.
  • Small PR is a single squashable commit; or, for a large PR, every commit is meaningful, well-formed, and independently reviewable (see CONTRIBUTING.md §Pull Requests).
  • No stray merge commits from master — the branch is rebased cleanly on top of the current master.
  • No fixup! / squash! / wip commits remain.

Scope and Design

  • Changes are minimal — no unrelated modifications were introduced (CONTRIBUTING.md §Code/General).
  • No dead code, commented-out blocks, debug prints, printf/std::cout/print(...) left behind, or TODO without an owner and issue link.
  • No unrelated formatting churn that would obscure the diff.
  • Public API changes (if any) are intentional, documented, and reflected in affected callers/tests.

General Code Hygiene

  • The code is self-explanatory; comments were added only where the intent or rationale is non-obvious (CONTRIBUTING.md §Code/General).
  • Every modified or added file ends with a single trailing newline (CONTRIBUTING.md §Code/General).
  • No trailing whitespace, inconsistent indentation, or mixed formatting styles remain.
  • Identifiers referenced in comments or error messages are wrapped in Markdown backticks (e.g. the `AllReduce` implementation) (CONTRIBUTING.md §Code/General).
  • All comments and error messages are in English (CONTRIBUTING.md §Code/General).
  • Comments and error messages are complete sentences — capitalized first letter, terminal punctuation — unless the language/framework convention says otherwise (CONTRIBUTING.md §Code/General; §Python).

C++ Specific (if C++ files changed)

  • Code follows the Google C++ Style Guide strictly.
  • clang-format (version 16, per .github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.
  • No exceptions are thrown. Error paths use assert with messages that include at least __FILE__, __LINE__, and __func__ (CONTRIBUTING.md §C++).
  • Error and warning message wording follows the LLVM Coding Standards (CONTRIBUTING.md §C++).
  • Constructor initializer list order matches member declaration order (CONTRIBUTING.md §C++).
  • Exactly one blank line between classes, between classes and functions, and between functions (CONTRIBUTING.md §C++).
  • Exactly one blank line between members (functions and variables) within a class (CONTRIBUTING.md §C++).
  • Exactly one blank line before and after the contents of a namespace (CONTRIBUTING.md §C++).

Python Specific (if Python files changed)

  • Code is PEP 8 compliant; ruff check passes cleanly on CI (see .github/workflows/ruff.yml).
  • ruff format --check passes cleanly — if not, run ruff format and commit the result.
  • Comments are complete English sentences, starting with a capital letter and ending with punctuation; Markdown backticks are used for code references (CONTRIBUTING.md §Python).
  • Framework-specific conventions (e.g. lowercase pytest.skip messages without terminal period) are honored where applicable (CONTRIBUTING.md §Python).
  • No blank line between the function signature and the body when there is no docstring or comment (CONTRIBUTING.md §Python).
  • A blank line is present before and after if, for, and similar control-flow statements (CONTRIBUTING.md §Python).
  • A blank line appears before each return, except when it directly follows a control-flow statement (CONTRIBUTING.md §Python).
  • Docstrings (if any) follow PEP 257 (CONTRIBUTING.md §Python).
  • Type hints are added / kept consistent with the surrounding code.

Testing

  • All applicable example programs have been built and tested successfully on at least one supported heterogeneous cluster setup.

Build, CI, and Tooling

  • New backends or devices have been added to auto-detection in CMakeLists.txt under if(AUTO_DETECT_DEVICES) or to if(AUTO_DETECT_BACKENDS) if applicable.
  • Both CI workflows (clang-format.yml, ruff.yml) are green locally (or expected to be green on CI).

Documentation

  • README.md, CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.
  • Any user-visible breaking change is called out explicitly under "Summary" and in the commit/PR title with a ! or BREAKING CHANGE: footer.

Security and Safety

  • No secrets, access tokens, internal URLs, customer data, or personal hardware identifiers have been committed.
  • N/A- Third-party code is license-compatible and attributed.
  • No unsafe pointer arithmetic, uninitialized reads, or missing bounds checks were introduced.

@Ziminli Ziminli self-assigned this Jul 15, 2026
@Ziminli Ziminli merged commit 7127fd2 into master Jul 15, 2026
2 checks passed
@Ziminli Ziminli deleted the feat/support-mccl-metax branch July 15, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant