feat: support MCCL on MetaX#50
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add MCCL backend support for MetaX by reusing the shared CCL backend abstraction. This PR adds a new
src/backends/ccl/mcclbackend layer, bindsBackendType::kMccltoDevice::Type::kMetax, and updates CMake/bridge generation so MetaX builds can discover, link, and generate code for MCCL.The implementation follows the same provider-oriented structure as NCCL: common CCL operation implementations are reused, while the MCCL-specific API wrapper, type map, operation registration, and MetaX provider alias live under
src/backends/ccl/mccl.Changes
MCCL backend support
src/backends/ccl/mcclbackend family, including the MCCL API wrapper, type mapping, checks, and operation registrations that reuse the common CCL implementation layer.MetaX integration
src/backends/ccl/mccl/metaxand markBackendType::kMcclwithDevice::Type::kMetaxas a supported backend/device combination.Build and generation
srcCMake logic to exposeWITH_MCCL, discover MetaX MCCL dependencies, and link the library/examples when MCCL is enabled.scripts/gen_bridge.pyso CCL provider headers and backend implementation headers are generated for MCCL in the same pattern as NCCL.Documentation and templates
README.mdwith MCCL backend documentation and.github/pull_request_template.mdwith MCCL backend checklist entries.Platform and Backend Affected
Platform
Backend
Performance Impact
N/A.
Known Issues & Future Work
GetUniqueId,CommInitRank,CommDestroy, andAllReduce.DataType::kInt16andDataType::kUInt16are mapped as unsupported for MCCL until the backend API supports them.src/backends/ccl/mccl/metax.Test Results
Test Involved Platform
Test Involved Backend
MetaX with MCCL:
ccl_all_reduce.log
MetaX with MCCL+OpenMPI:
ccl_mpi_hybrid_all_reduce.log
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).Python Specific (if Python files changed)
ruff checkpasses cleanly on CI (see.github/workflows/ruff.yml).ruff format --checkpasses cleanly — if not, runruff formatand commit the result.CONTRIBUTING.md§Python).pytest.skipmessages without terminal period) are honored where applicable (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).if,for, and similar control-flow statements (CONTRIBUTING.md§Python).return, except when it directly follows a control-flow statement (CONTRIBUTING.md§Python).CONTRIBUTING.md§Python).Testing
Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety