feat: Add ContactCard state, primitives and small components - #820
Open
Elouan1411 wants to merge 8 commits into
Open
feat: Add ContactCard state, primitives and small components#820Elouan1411 wants to merge 8 commits into
Elouan1411 wants to merge 8 commits into
Conversation
Elouan1411
force-pushed
the
vcard-2-setup-module
branch
from
July 24, 2026 06:59
0bafc8e to
aae8c4b
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
July 24, 2026 06:59
2af33ef to
74b2c73
Compare
Elouan1411
force-pushed
the
vcard-2-setup-module
branch
from
July 24, 2026 07:21
aae8c4b to
4f33bc9
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
July 24, 2026 07:23
74b2c73 to
4772e69
Compare
Elouan1411
force-pushed
the
vcard-2-setup-module
branch
from
July 24, 2026 07:26
4f33bc9 to
18b6d27
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
July 24, 2026 07:28
4772e69 to
d1fb95a
Compare
Elouan1411
changed the title
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
July 24, 2026 07:53
d1fb95a to
f11001f
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
July 24, 2026 07:56
f11001f to
71026ed
Compare
Elouan1411
force-pushed
the
vcard-3-viewmodel-primitives
branch
from
July 24, 2026 08:09
71026ed to
fdb1a22
Compare
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds reusable state, styling defaults, and Compose primitives for the Contact Card feature.
Changes:
- Adds top-bar state and customizable colors.
- Adds editor, preview, loading, dialog, and layout components.
- Adds preview fixtures for contact-card UI tooling.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
ContactCardTopBarState.kt |
Defines top-bar modes and callbacks. |
ContactCardDefaults.kt |
Provides theme-aware card colors. |
SectionCard.kt |
Adds section container UI. |
PreviewTopBar.kt |
Adds preview navigation actions. |
PreviewData.kt |
Provides preview model fixtures. |
LoadingContent.kt |
Adds centered loading UI. |
FieldDivider.kt |
Adds field separator styling. |
EditorTopBar.kt |
Adds editor cancel/save actions. |
EditorField.kt |
Adds reusable single-line input. |
DefaultValidationErrorDialog.kt |
Adds validation error dialog. |
DefaultDeleteConfirmationDialog.kt |
Adds deletion confirmation dialog. |
ContactInfoRows.kt |
Displays available contact information. |
ContactCardTopBar.kt |
Adds shared centered top bar. |
ContactCardConstants.kt |
Defines shared card radius. |
BottomSheetAction.kt |
Adds reusable bottom-sheet action row. |
| IconButton(onClick = onClose) { | ||
| Icon( | ||
| imageVector = Icons.Filled.Close, | ||
| contentDescription = stringResource(RCore.string.buttonCancel), |
| onDismissRequest = onDismiss, | ||
| confirmButton = { | ||
| TextButton(onClick = onConfirm) { | ||
| Text(text = stringResource(android.R.string.ok)) |
Comment on lines
+44
to
+46
| card.links.orEmpty().firstOrNull { it.type == CardLinkType.Website }?.let { | ||
| add(stringResource(R.string.webSite) to it.url) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.