feat: Can now release snapshot - #12
Merged
Merged
Conversation
baillyjamy
force-pushed
the
feat/ios-kmp-snapshot-worklows
branch
from
August 5, 2026 13:33
bde7add to
0712c48
Compare
There was a problem hiding this comment.
Pull request overview
Adds snapshot publishing support for the KMP library and its Apple XCFramework.
Changes:
- Adds Swift Package and manual iOS snapshot publishing.
- Configures NMCP Maven Central aggregation.
- Removes pull-request XCFramework build validation.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Package.swift |
Defines the binary Swift package. |
gradle/kmpAuthenticator.versions.toml |
Adds NMCP plugins. |
build.gradle.kts |
Configures Central Portal aggregation. |
build-logic/plugins/src/main/kotlin/buildlogic/publish/PublishPlugin.kt |
Applies NMCP to published modules. |
.github/workflows/publish-ios-snapshot.yml |
Adds manual snapshot publishing. |
.github/workflows/build-xcframework.yml |
Removes Apple PR build validation. |
Suppressed comments (1)
.github/workflows/build-xcframework.yml:1
- This deletes the only pull-request job that compiles the Apple XCFramework; the remaining PR workflows only validate metadata/wrapper concerns, while the new snapshot workflow is manual. As a result, Apple compilation failures can now merge and will only be discovered when someone attempts a snapshot. Please retain this check or add equivalent
pull_requestXCFramework validation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sirambd
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.