Skip to content

fix: Workaround closed Room throwing JobCancellationException #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LouisCAD merged 1 commit into from
Aug 6, 2026
+16 −2
Merged

fix: Workaround closed Room throwing JobCancellationException #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions AuthenticatorCore/src/androidMain/kotlin/internal/otp/TotpGenerator.android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,24 @@ package com.infomaniak.multiplatform_authenticator.core.internal.otp

import com.infomaniak.multiplatform_authenticator.core.internal.models.LegacyUser
import com.infomaniak.multiplatform_authenticator.core.internal.room.legacy.OTPUserDatabase
import kotlinx.coroutines.CancellationException
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.currentCoroutineContext
import kotlinx.coroutines.isActive
import kotlinx.coroutines.withContext
import splitties.init.appCtx

internal actual suspend fun getLegacyAccounts(): List<LegacyUser> {
return OTPUserDatabase.instance.otpUserDao().getAllUsers()
if (legacyDbExists().not()) return emptyList()
val db = OTPUserDatabase.instance
return try {
db.otpUserDao().getAllUsers()
} catch (e: CancellationException) {
if (currentCoroutineContext().isActive && db.isOpen.not()) {
// Thrown by Room, see this issue: https://issuetracker.google.com/issues/543076356
emptyList()
} else throw e
}
}

internal actual suspend fun deleteLegacyAccount(userId: String) {
Expand All @@ -44,4 +56,6 @@ internal actual suspend fun getSecretFor(userId: Long): String? {
return getLegacyAccounts().find { it.userId.toLong() == userId }?.secret
}

internal actual suspend fun needMigration() = withContext(Dispatchers.IO) { appCtx.getDatabasePath("Infomaniak.db").exists() }
internal actual suspend fun needMigration() = legacyDbExists()

private suspend fun legacyDbExists() = withContext(Dispatchers.IO) { appCtx.getDatabasePath("Infomaniak.db").exists() }
Loading